Repository navigation
Qualify provider auth through real web card callbacks - #1482
Merged
Merged
Conversation
7 of 53 tasks
7 of 51 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real callback/public-runtime provider-auth browser matrix
Refs #1458 and #1442; both stay open. Offline qualification continues without target/scope waivers.
Add a disposable Chromium/WebKit fixture using the actual DB-backed WebAdaptiveCardSidePromptService, login handler and public ModelRuntime/FileCredentialStore with a typed faux provider. The TestSession supplies bookkeeping only.
Scope is fresh-source browser fixture with real service/public runtime, not packed CLI/web artifact, production HTTP authentication middleware, real-provider device polling or approved live account acceptance. No inference/deployment/restart/native-MCP activation.
Validation
Chromium/WebKit: 8 pass / 80 assertions. Five standard types, strict server-fixture typing using existing dependency declarations, scoped lint and diff pass. Independent review corrections applied and final scoped review found no blocker. Browser module built from current renderer/dialog. Frozen canonical gate: 5,970 passed, eight existing/opt-in skips, zero failed; 25 feature and nine web checks passed. Browser files are excluded there and separately executed at8/80. Pack hygiene: 24,742 files. Final five types/diff passed at baseline
b50df2771; unchanged compose baseline. Private Bun cache, no shared-cache permission changes. Env observation snapshot has only documentation references to existing opt-in flags.