Couple of fixes so plugin will pass Strict checks.#11
Open
thoth wants to merge 3 commits intorchavik:masterfrom
Open
Couple of fixes so plugin will pass Strict checks.#11thoth wants to merge 3 commits intorchavik:masterfrom
thoth wants to merge 3 commits intorchavik:masterfrom
Conversation
added 3 commits
October 16, 2013 16:23
Modified beforeRender parameters to pass Strict checks.
Modified afterFind parameters to pass Strict check.
beforeFind was duplicating records (specifically links) in cases where there was more than one site. The array_unique was appending the current site to the CONST = 1 and would always return "array(1,x)" where x is the "id" of the current site (if the current site id > 1).
Owner
|
Hi, Sorry about the delay. Must have read the notification and forgot about it. I've merged the first two commits, but leaving out 2d449c7 for now. Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.