RDKB-62903 TCM RFC update request - configuration by VAP#1071
RDKB-62903 TCM RFC update request - configuration by VAP#1071Sneha3821 wants to merge 10 commits intordkcentral:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the existing TCM RFC configuration from a single global flag (Device.WiFi.Tcm) to per-VAP/band flags exposed under Device.WiFi.TCM.*, and persists those settings into the Wifi_Rfc_Config OVSDB table so downstream components can consume them.
Changes:
- Adds new TR-181 object
Device.WiFi.TCM.{Open2G,Open5G,Open6G,Secure2G,Secure5G,Secure6G}with DML get/set handlers. - Extends Wifi_Rfc_Config (OVSDB + schema bindings) and internal RFC parameter structs to store the new per-VAP TCM flags.
- Wires new RFC events through the ctrl queue handler and adds a startup compatibility update to populate per-VAP flags when upgrading from the legacy global-only enable.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| source/dml/tr_181/ml/cosa_wifi_dml.c | Adds TR-181 DML getters/setters for Device.WiFi.TCM.* booleans, pushing updates via ctrl-queue events. |
| source/db/wifi_db_apis.c | Persists new per-VAP TCM RFC flags in Wifi_Rfc_Config cache/get/update paths; adds upgrade-time defaulting when legacy TCM was enabled. |
| source/core/wifi_ctrl_queue_handlers.c | Adds handlers for new per-VAP TCM RFC events and routes them to RFC config update. |
| source/core/wifi_ctrl.c | Extends get_ctrl_rfc_parameters() to copy new per-VAP TCM flags into ctrl RFC params. |
| lib/inc/schema_gen.h | Adds schema bindings for new Wifi_Rfc_Config boolean columns. |
| include/wifi_events.h | Introduces new event subtypes for per-VAP TCM RFC updates. |
| include/wifi_base.h | Extends wifi_rfc_dml_parameters_t to include new per-VAP TCM RFC flags. |
| config/rdkb-wifi.ovsschema | Adds new Wifi_Rfc_Config columns for per-VAP TCM RFC flags and bumps schema version. |
| config/TR181-WiFi-USGv2.XML | Adds TR-181 TCM object and parameters mapping to the new DML functions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
This PR extends the existing Transient Client Management (TCM) RFC configuration to support per‑VAP enablement via TR-181, persisting the new flags in OVSDB and propagating updates through the controller event pipeline.
Changes:
- Adds TR-181
Device.WiFi.TCM.*boolean parameters (Open/Secure per band) with new DML get/set handlers. - Extends the Wifi_Rfc_Config OVSDB schema + internal RFC parameter struct to carry the new per‑VAP TCM flags.
- Adds new controller event subtypes and queue handling to apply updates into the RFC config.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| source/dml/tr_181/ml/cosa_wifi_dml.c | Adds TCM_GetParamBoolValue / TCM_SetParamBoolValue to expose per‑VAP TCM RFC toggles via TR-181. |
| source/db/wifi_db_apis.c | Plumbs new per‑VAP TCM fields through OVSDB monitor callbacks, get/update APIs, defaults, and a version-gated migration. |
| source/core/wifi_ctrl_queue_handlers.c | Adds per‑VAP TCM RFC event handlers and dispatch cases. |
| source/core/wifi_ctrl.c | Ensures controller RFC parameter snapshot includes the new TCM per‑VAP fields. |
| lib/inc/schema_gen.h | Adds generated schema bindings for the new Wifi_Rfc_Config columns. |
| include/wifi_events.h | Introduces new event subtypes for per‑VAP TCM RFC updates. |
| include/wifi_base.h | Extends wifi_rfc_dml_parameters_t with per‑VAP TCM booleans. |
| config/rdkb-wifi.ovsschema | Adds new tcm_*_rfc boolean columns to Wifi_Rfc_Config. |
| config/TR181-WiFi-USGv2.XML | Adds new TCM object under Device.WiFi with writable per‑VAP parameters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RDKB-62903 - TCM RFC update request - configuration by VAP
Reason For Change : TCM RFC is configured at Device.WiFi.Tcm and applies to all VAPs.
Test Procedure: Enable TCM RFC per VAP via DMCLI, verify the update in OVSDB, and confirm TCM logic execution through logs.
dmcli eRT getv Device.WiFi.Tcm
dmcli eRT setv Device.WiFi.Tcm bool true
dmcli eRT getv Device.WiFi.TCM.Open2G
dmcli eRT getv Device.WiFi.TCM.Open5G ``dmcli eRT getv Device.WiFi.TCM.Open6G
dmcli eRT getv Device.WiFi.TCM.Secure2G
dmcli eRT getv Device.WiFi.TCM.Secure5G
dmcli eRT getv Device.WiFi.TCM.Secure6G
/usr/opensync/tools/ovsh s Wifi_Rfc_Config -c -d wifi
/nvram/wifiTCMDbg
wifiTransientClientMgmtCtrl
Priority: P1
Risks: Low
Signed-off-by: Sneha Kannan , sneha_kannan@comcast.com