RDKB-64347: Fixing coverity issues#1074
Open
bharathivelp wants to merge 1 commit intordkcentral:developfrom
Open
RDKB-64347: Fixing coverity issues#1074bharathivelp wants to merge 1 commit intordkcentral:developfrom
bharathivelp wants to merge 1 commit intordkcentral:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes several Coverity findings across passpoint, webconfig analytics logging, and blaster measurement code paths.
Changes:
- Replaced unsafe
strcpy()with boundedsnprintf()for HESSID copies in passpoint interworking config. - Refactored interworking element handling under
ENABLE_FEATURE_MESHWIFI(now heap-allocateselem). - Removed an unused return-status variable and simplified analytics status formatting; removed redundant
buff = NULLafterfree().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
source/core/wifi_passpoint.c |
Hardens HESSID copies and refactors interworking element initialization logic for mesh builds. |
source/core/wifi_ctrl_webconfig.c |
Removes unused variable and simplifies analytics “success” formatting on successful apply. |
source/apps/blaster/wifi_single_client_msmt.c |
Removes redundant nulling of a freed buffer pointer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bharathivelp
force-pushed
the
RDKB-MCoverity_fixes
branch
from
5d241e9 to
927c288
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bharathivelp
force-pushed
the
RDKB-MCoverity_fixes
branch
from
a3269c1 to
e5cf72f
Compare
Reason for change: Fixing Low priority Coverity issues. Test Procedure: Build should be successful and the regression test should also succeed. Risks: Low Priority: P1 Signed-off-by: Velpula_Bharathi@comcast.com
bharathivelp
force-pushed
the
RDKB-MCoverity_fixes
branch
from
e5cf72f to
4940ed4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fixing Low priority coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed.
Risks: Low
Priority: P1
Signed-off-by: Velpula_Bharathi@comcast.com