XF10-284 : Remove Unnecessary flags for XF10 (#734)#1088
Open
bytegowda wants to merge 2 commits intordkcentral:mainfrom
Open
XF10-284 : Remove Unnecessary flags for XF10 (#734)#1088bytegowda wants to merge 2 commits intordkcentral:mainfrom
bytegowda wants to merge 2 commits intordkcentral:mainfrom
Conversation
Reason for change: Remove flags -DSKY -DBRCM_CMS_MSG -D_SKY_HUB_COMMON_PRODUCT_REQ and added flag PON_GATEWAY Test Procedure: WiFi should work as expected for XF10 Risks: none Priority: P2 Signed-off-by: Yashwanth Kumar H M <yashwanthkumar.hm@sky.uk> Co-authored-by: yashwanthkumar-hm_comcast <yashwanthkumar.hm@sky.uk>
gsathish86
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Remove flags -DSKY -DBRCM_CMS_MSG -D_SKY_HUB_COMMON_PRODUCT_REQ and added flag PON_GATEWAY
Test Procedure:
WiFi should work as expected for XF10
Risks: none
Priority: P2