RDKB-64347: Fixing coverity issues by bharathivelp · Pull Request #1096 · rdkcentral/OneWifi

bharathivelp · 2026-04-27T08:10:32Z

Reason for change: Fixing Low priority coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed.

Risks: Low
Priority: P1
Signed-off-by: Velpula_Bharathi@comcast.com

Copilot

Pull request overview

This PR addresses Coverity-reported issues across WiFi monitoring, webconfig consumer logging, and the WiFi blaster active-measurement flow.

Changes:

Removes an ineffective/null check and simplifies disconnect cleanup logic in associated-client stats collection.
Adjusts STA connection status log formatting in the webconfig consumer.
Avoids holding the blaster mutex while collecting (potentially slow) system health stats by restructuring the resource-gathering condition.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
`source/stats/wifi_stats_assoc_client.c`	Removes dead/null logic, tweaks disconnect removal condition, and adds a `sta_map` NULL guard before event building.
`source/sampleapps/webconfig_consumer_apis.c`	Updates STA connect/disconnect printf formats.
`source/apps/blaster/wifi_blaster.c`	Refactors resource collection into a `resource_ok` boolean and releases the mutex during resource collection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-29T12:44:19Z

+#define CSI_TMP_TEMPLATE "/tmp/CSI_tmp.bin"
    WIFI_EVENT_CONSUMER_DGB("Enter %s: %d\n", __FUNCTION__, __LINE__);
    char filename[] = CSI_FILE;
-    char filename_tmp[] = CSI_TMP_FILE;
-    FILE *csifptr;
-    FILE *csifptr_tmp;
+    char filename_tmp[] = CSI_TMP_TEMPLATE;
+    FILE *csifptr = NULL;
+    FILE *csifptr_tmp = NULL;


CSI_TMP_TEMPLATE is not actually a template (it’s a fixed filename in /tmp), and creating a predictable temp file in /tmp via fopen(..., "w") is susceptible to symlink/clobber attacks. Please switch to a securely-created temporary file (e.g., mkstemp/open with O_EXCL) and then rename it into place, or otherwise ensure the temp path cannot be pre-created/redirected by another process.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-30T12:39:50Z

+        if (fread(&tmp_mac, sizeof(tmp_mac), 1, csifptr) != 1 ||
+            fread(&tmp_frame_info, sizeof(tmp_frame_info), 1, csifptr) != 1 ||
+            fread(&tmp_csi_matrix, sizeof(tmp_csi_matrix), 1, csifptr) != 1) {
+            WIFI_EVENT_CONSUMER_DGB("Failed to read oldest CSI record\n");


When dropping the oldest record, a partial read (e.g., first fread succeeds but the second/third fails) leaves the file position mid-record, and the subsequent copy loop will read/write misaligned data into the new file. Consider treating this as a hard failure for rotation (e.g., abort copying and start a fresh file, or rewind and copy from the beginning without dropping) instead of continuing after a failed drop.

Suggested change

WIFI_EVENT_CONSUMER_DGB("Failed to read oldest CSI record\n");

WIFI_EVENT_CONSUMER_DGB("Failed to read oldest CSI record, copying from the beginning instead\n");

if (fseek(csifptr, 0, SEEK_SET) != 0) {

WIFI_EVENT_CONSUMER_DGB("Failed to rewind CSI file after partial oldest-record read: %s\n", strerror(errno));

csifptr = NULL;

}

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-30T13:12:49Z

+    if (sscanf(event->name, "Device.WiFi.STA.%d.InterfaceName", &index) != 1) {
+        printf("%s:%d sscanf failed to parse index from event name\n", __FUNCTION__, __LINE__);
+        return;
+    }


index is declared as unsigned int, but the sscanf format string uses %d (expects int*). This is undefined behavior. Use %u (or change index to int and validate it) to make the types consistent.

Reason for change: Fixing Low priority Coverity issues. Test Procedure: Build should be successful and the regression test should also succeed. Risks: Low Priority: P1 Signed-off-by: Velpula_Bharathi@comcast.com

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-30T15:59:54Z

+    snprintf(str, sizeof(str), "%s", name);
+    if (sscanf(str, "Device.WiFi.STA.%u.%s", &index, extension) != 2) {
+        wifi_util_error_print(WIFI_CTRL, "%s Invalid property name format %s\n", __FUNCTION__, str);
+        return bus_error_invalid_input;
+    }


snprintf(str, sizeof(str), "%s", name) can truncate long property names without detection; parsing a truncated string can make an invalid/partial property look valid. Also, sscanf(..., "%u.%s", ...) uses an unbounded %s, which can overflow extension[64] if the suffix is longer than 63 bytes. Consider rejecting truncation (check snprintf return) and bounding the scan with a field width (or parse directly from name using bounded specifiers).

bharathivelp requested a review from a team as a code owner April 27, 2026 08:10

navyasher requested a review from Copilot April 27, 2026 09:53

Copilot started reviewing on behalf of navyasher April 27, 2026 09:54 View session

Copilot AI reviewed Apr 27, 2026

View reviewed changes

Comment thread source/sampleapps/webconfig_consumer_apis.c Outdated

Comment thread source/apps/blaster/wifi_blaster.c Outdated

Comment thread source/stats/wifi_stats_assoc_client.c Outdated

Comment thread source/sampleapps/webconfig_consumer_apis.c Outdated

bharathivelp force-pushed the RDKB_LOW_ISSUES branch from 157bd13 to 13211a6 Compare April 27, 2026 10:25

navyasher requested a review from Copilot April 27, 2026 10:55

Copilot started reviewing on behalf of navyasher April 27, 2026 10:55 View session

Copilot AI reviewed Apr 27, 2026

View reviewed changes

bharathivelp force-pushed the RDKB_LOW_ISSUES branch 2 times, most recently from a04e6b5 to 6bcb5ab Compare April 29, 2026 12:14

navyasher requested a review from Copilot April 29, 2026 12:40

Copilot started reviewing on behalf of navyasher April 29, 2026 12:41 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

navyasher force-pushed the RDKB_LOW_ISSUES branch from 6bcb5ab to 100fb87 Compare April 29, 2026 14:26

navyasher requested a review from Copilot April 29, 2026 14:27

Copilot started reviewing on behalf of navyasher April 29, 2026 14:28 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread source/sampleapps/wifievents_consumer_sample.c Outdated

navyasher force-pushed the RDKB_LOW_ISSUES branch from 100fb87 to 78e2ae2 Compare April 29, 2026 15:37

navyasher requested a review from Copilot April 29, 2026 15:37

Copilot started reviewing on behalf of navyasher April 29, 2026 15:38 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread source/sampleapps/webconfig_consumer_apis.c

Comment thread source/sampleapps/wifievents_consumer_sample.c

Comment thread source/sampleapps/wifievents_consumer_sample.c

navyasher force-pushed the RDKB_LOW_ISSUES branch 3 times, most recently from d9fe651 to f54cf35 Compare April 30, 2026 10:57

bharathivelp force-pushed the RDKB_LOW_ISSUES branch from f54cf35 to 0b4e4a6 Compare April 30, 2026 12:11

navyasher requested a review from Copilot April 30, 2026 12:31

Copilot started reviewing on behalf of navyasher April 30, 2026 12:36 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

bharathivelp force-pushed the RDKB_LOW_ISSUES branch from 0b4e4a6 to 5d5a08c Compare April 30, 2026 13:06

navyasher requested a review from Copilot April 30, 2026 13:07

Copilot started reviewing on behalf of navyasher April 30, 2026 13:08 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

RDKB-64347: Fixing coverity issues

726b90f

Reason for change: Fixing Low priority Coverity issues. Test Procedure: Build should be successful and the regression test should also succeed. Risks: Low Priority: P1 Signed-off-by: Velpula_Bharathi@comcast.com

navyasher force-pushed the RDKB_LOW_ISSUES branch from 5d5a08c to 726b90f Compare April 30, 2026 15:54

navyasher requested a review from Copilot April 30, 2026 15:55

Copilot started reviewing on behalf of navyasher April 30, 2026 15:56 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

-            WIFI_EVENT_CONSUMER_DGB("Failed to read oldest CSI record\n");
+            WIFI_EVENT_CONSUMER_DGB("Failed to read oldest CSI record, copying from the beginning instead\n");
+            if (fseek(csifptr, 0, SEEK_SET) != 0) {
+                WIFI_EVENT_CONSUMER_DGB("Failed to rewind CSI file after partial oldest-record read: %s\n", strerror(errno));
+                csifptr = NULL;
+            }

Conversation

bharathivelp commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bharathivelp commented Apr 27, 2026 •

edited

Loading