Skip to content

RDKB-64347: Fixing coverity issues#1098

Open
vanshika-singhal24 wants to merge 2 commits intordkcentral:developfrom
vanshika-singhal24:RDKB-VStack/String
Open

RDKB-64347: Fixing coverity issues#1098
vanshika-singhal24 wants to merge 2 commits intordkcentral:developfrom
vanshika-singhal24:RDKB-VStack/String

Conversation

@vanshika-singhal24
Copy link
Copy Markdown
Contributor

@vanshika-singhal24 vanshika-singhal24 commented Apr 28, 2026

Reason for change: Fixing low priority coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed.

Risks: Low
Priority: P1
Signed-off-by: vanshika_lnu@comcast.com

@vanshika-singhal24 vanshika-singhal24 requested a review from a team as a code owner April 28, 2026 10:35
@vanshika-singhal24 vanshika-singhal24 changed the title Reason for change: Fixing low priority coverity issues. RDKB-64347: Fixing coverity issues Apr 28, 2026
@navyasher navyasher requested a review from Copilot April 28, 2026 12:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to address low-priority Coverity findings across the WiFi utilities, monitoring, and control-path code by tightening buffer handling and adjusting some data-structure usage.

Changes:

  • Adds buffer-length-aware ping frame construction for ICMPv4/ICMPv6 (replacing unsafe string copies).
  • Refactors hotspot/LnF VAP handling to use dynamically allocated wifi_vap_info_t.
  • Refactors host-sync logic to use dynamically allocated LM_wifi_hosts_t and introduces a mutex field in that struct.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
source/utils/wifi_util.h Adds hosts_lock to LM_wifi_hosts_t and removes packing attributes.
source/stats/wifi_monitor.c Makes ping framing functions static and adds buffer_len + safer payload formatting.
source/core/wifi_ctrl_queue_handlers.c Introduces heap allocation/cleanup paths for hotspot/LnF handling and host-sync data structures; adds mutex init/destroy.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/utils/wifi_util.h Outdated
Comment thread source/core/wifi_ctrl_queue_handlers.c Outdated
Comment thread source/stats/wifi_monitor.c
Comment thread source/stats/wifi_monitor.c
Test Procedure: Build should be successful and the regression test should also succeed.

Risks: Low
Priority: P1
Signed-off-by: vanshika_lnu@comcast.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants