RDKB-64347: Fixing coverity issues#1098
Open
vanshika-singhal24 wants to merge 2 commits intordkcentral:developfrom
Open
RDKB-64347: Fixing coverity issues#1098vanshika-singhal24 wants to merge 2 commits intordkcentral:developfrom
vanshika-singhal24 wants to merge 2 commits intordkcentral:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to address low-priority Coverity findings across the WiFi utilities, monitoring, and control-path code by tightening buffer handling and adjusting some data-structure usage.
Changes:
- Adds buffer-length-aware ping frame construction for ICMPv4/ICMPv6 (replacing unsafe string copies).
- Refactors hotspot/LnF VAP handling to use dynamically allocated
wifi_vap_info_t. - Refactors host-sync logic to use dynamically allocated
LM_wifi_hosts_tand introduces a mutex field in that struct.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
source/utils/wifi_util.h |
Adds hosts_lock to LM_wifi_hosts_t and removes packing attributes. |
source/stats/wifi_monitor.c |
Makes ping framing functions static and adds buffer_len + safer payload formatting. |
source/core/wifi_ctrl_queue_handlers.c |
Introduces heap allocation/cleanup paths for hotspot/LnF handling and host-sync data structures; adds mutex init/destroy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2ba737c to
c89b071
Compare
Test Procedure: Build should be successful and the regression test should also succeed. Risks: Low Priority: P1 Signed-off-by: vanshika_lnu@comcast.com
52a4f46 to
3bab3d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fixing low priority coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed.
Risks: Low
Priority: P1
Signed-off-by: vanshika_lnu@comcast.com