RDKTV-40024: Fix proper cleanup service#2100
Open
SatheeshkumarG15 wants to merge 2 commits intomasterfrom
Open
RDKTV-40024: Fix proper cleanup service#2100SatheeshkumarG15 wants to merge 2 commits intomasterfrom
SatheeshkumarG15 wants to merge 2 commits intomasterfrom
Conversation
…esourceMonitor or Workerpool thread to properly clear out the service and to avoid the crash
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves connection/service cleanup in Thunder’s daemon runtime by centralizing channel-to-service detachment logic and making it idempotent, preventing double-cleanup paths during socket close/destruction.
Changes:
- Introduce
Server::Channel::CleanupService()to consolidateUnsubscribe/Detach/Releasefor_service. - Ensure cleanup is executed in both
StateChange()close handling and~Channel()without double-invocation by guarding via an atomic flag. - Add initialization for the new cleanup guard in
PluginServer.cpp.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Source/Thunder/PluginServer.h | Adds CleanupService() and an atomic “cleanup-once” guard; updates close path to call the helper. |
| Source/Thunder/PluginServer.cpp | Initializes _serviceCleanedUp and updates the channel destructor to use CleanupService(). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.