[Messaging] Make output configurable depending on message metadata#2101
Open
VeithMetro wants to merge 8 commits intomasterfrom
Open
[Messaging] Make output configurable depending on message metadata#2101VeithMetro wants to merge 8 commits intomasterfrom
VeithMetro wants to merge 8 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces configurable message output routing based on message metadata, allowing messages to be routed to the MessageControl plugin buffer, direct output, or both.
Changes:
- Added
OutputModeenum and JSON-configurableoutputfields at section and per-entry level. - Added settings-side routing map and lookup (
EffectiveOutput) plus direct-mode buffer creation override (HasPluginOutput). - Updated
MessageUnit::Push()to route each message according to the effective output mode.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
Source/messaging/MessageUnit.h |
Adds OutputMode, JSON config fields, routing map, and routing resolution logic used to decide buffer creation and per-message routing. |
Source/messaging/MessageUnit.cpp |
Adds enum<->string conversion and updates Push() to send messages direct/plugin/both based on the new routing logic. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| uint8_t routeMode = Core::NumberType<uint8_t>(iterator.Current()).Value(); | ||
| if ((type >= Core::Messaging::Metadata::type::TRACING) && (type <= Core::Messaging::Metadata::type::TELEMETRY) && | ||
| (routeMode <= static_cast<uint8_t>(MessageUnit::BOTH))) { | ||
| _outputRouting[{static_cast<Core::Messaging::Metadata::type>(type), category, module}] = static_cast<OutputMode>(routeMode); |
| uint8_t routeMode = Core::NumberType<uint8_t>(iterator.Current()).Value(); | ||
| if ((type >= Core::Messaging::Metadata::type::TRACING) && (type <= Core::Messaging::Metadata::type::TELEMETRY) && | ||
| (routeMode <= static_cast<uint8_t>(MessageUnit::BOTH))) { | ||
| _outputRouting[{static_cast<Core::Messaging::Metadata::type>(type), category, module}] = static_cast<OutputMode>(routeMode); |
sebaszm
requested changes
Apr 27, 2026
Contributor
sebaszm
left a comment
sebaszm
left a comment
There was a problem hiding this comment.
Rename enums 'plugin' to 'handler' and 'both' to 'all'. Simplify by making the output mode a control property as discussed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.