CPESP-9115 : Change sessionID from uint32 to string#490
Open
npoltorapavlo wants to merge 1 commit intordkcentral:masterfrom
Open
CPESP-9115 : Change sessionID from uint32 to string#490npoltorapavlo wants to merge 1 commit intordkcentral:masterfrom
npoltorapavlo wants to merge 1 commit intordkcentral:masterfrom
Conversation
npoltorapavlo
force-pushed
the
topic/CPESP-9115
branch
from
d8d283e to
fca311c
Compare
Reason for change: Current CPS plugin has sessionId as uint32, change that to string as per HLD document. Add a new interface that can take error ID as parameter and returns the error message. Test Procedure: None Risks: Low version: Patch
npoltorapavlo
force-pushed
the
topic/CPESP-9115
branch
from
fca311c to
8c29b67
Compare
There was a problem hiding this comment.
Pull request overview
Updates the Thunder Exchange ContentProtection interfaces to represent sessionId as a string (per HLD) and introduces a new interface for converting error codes to human-readable strings.
Changes:
- Added a new interface ID (
ID_ERRORTOSTRING) for a new RPC interface. - Updated
IContentProtectionAPIs to usestringforsessionId(including notification payloads). - Added
IErrorToStringinterface with anErrorToString(code, result)method.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| interfaces/Ids.h | Adds a new interface ID constant for the new IErrorToString interface. |
| interfaces/IContentProtection.h | Changes sessionId type to string, adjusts RPC annotations, switches several API return types to Core::hresult, and adds the new IErrorToString interface definition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+73
to
+74
| virtual Core::hresult Register(INotification* notification) = 0; | ||
| virtual Core::hresult Unregister(INotification* notification) = 0; |
Contributor
Author
There was a problem hiding this comment.
all sides will be updated together , no IContentProtection2 is needed
Comment on lines
+65
to
77
| // @text onWatermarkStatusChanged | ||
| // @param sessionId session id for the content protection session | ||
| // (e.g. 930762523) | ||
| // (e.g. "930762523") | ||
| // @param appId application that should receive the notification | ||
| virtual void WatermarkStatusChanged( | ||
| uint32_t sessionId /* @text:sessionId */, | ||
| const string& appId /* @text:appId */, | ||
| const Status& status) | ||
| = 0; | ||
| virtual void WatermarkStatusChanged(const string& sessionId, | ||
| const string& appId, const Status& status) = 0; | ||
| }; | ||
|
|
||
| virtual uint32_t Register(INotification* notification) = 0; | ||
| virtual uint32_t Unregister(INotification* notification) = 0; | ||
| virtual Core::hresult Register(INotification* notification) = 0; | ||
| virtual Core::hresult Unregister(INotification* notification) = 0; | ||
|
|
||
| // @alt openDrmSession | ||
| // @text openDrmSession | ||
| // @param clientId client that establishes the playback session |
Contributor
Author
There was a problem hiding this comment.
need camelCase, keeping both names is not necessary
|
|
||
| // @text errorToString | ||
| virtual Core::hresult ErrorToString( | ||
| const int32_t code, string& result /* @out */) const = 0; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Current CPS plugin has sessionId as uint32,
change that to string as per HLD document.
Add a new interface that can take error ID as parameter
and returns the error message.
Test Procedure: None
Risks: Low
version: Patch