Skip to content

[MessageControl] Adding new message types will not require changes in the UI#121

Merged
VeithMetro merged 1 commit intomasterfrom
development/messaging-telemetry
Apr 20, 2026
Merged

[MessageControl] Adding new message types will not require changes in the UI#121
VeithMetro merged 1 commit intomasterfrom
development/messaging-telemetry

Conversation

@VeithMetro
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 3, 2026 09:02
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Messaging UI to pass through the message type provided by the backend/API, removing the UI-side mapping from module names to message types so new message types can be supported without UI code changes.

Changes:

  • Changed enableControl to accept an explicit type parameter and forward it in the RPC payload.
  • Updated toggleControl to call enableControl with control.type.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@VeithMetro VeithMetro requested a review from sebaszm April 3, 2026 13:00
@VeithMetro VeithMetro merged commit 1994e3a into master Apr 20, 2026
10 checks passed
@VeithMetro VeithMetro deleted the development/messaging-telemetry branch April 20, 2026 11:14
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants