fix to prevent firewall restart on a bridgemode_event change#64
fix to prevent firewall restart on a bridgemode_event change#64akumar0702 wants to merge 9 commits intodevelopfrom
Conversation
…rt continously in 8.3p8s1 Reason for change: Bridgemode event is triggering a firewall restart, added fix to restart firewall only if the bridemode event value is different. Test Procedure: set bridgemode to same value multiple times advsec shouldn't restart firewall. Risks: Low Signed-off-by: arunkumar_nagulapally@comcast.com
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Pull request overview
Prevents repeated firewall restarts caused by repeated bridge_mode sysevent notifications carrying the same value, improving stability of AdvSecurity/CujoAgent behavior on 8.3p8s1.
Changes:
- Track the previous bridge mode value and early-return when an identical value is received.
- Add basic validation to reject non-1-character bridge mode values before acting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I have read the CLA Document and I hereby sign the CLA |
SanthoshGujulvajagadeesh
left a comment
SanthoshGujulvajagadeesh
left a comment
There was a problem hiding this comment.
Address copilot review comments and update unit test cases
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ring firewall commands for supported values.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| extern "C" char prevBridgeMode[2]; | ||
|
|
||
| class CcspAdvSecurityInternalTestFixture : public ::testing::Test { | ||
| protected: | ||
| void SetUp() override { | ||
| prevBridgeMode[0] = '\0'; |
| #ifndef UNIT_TEST_DOCKER_SUPPORT | ||
| #define STATIC static | ||
| #else | ||
| #define STATIC |
RDKB-64489: [Field][DA]: Observed CujoAgent triggering firewall restart continously in 8.3p8s1
Reason for change: Bridgemode event is triggering a firewall restart, added fix to restart firewall only if the bridemode event value is different.
Test Procedure: set bridgemode to same value multiple times advsec shouldn't restart firewall.
Risks: Low
Signed-off-by: arunkumar_nagulapally@comcast.com