XF10-696: Correct MAC address format on agent side#65
Merged
SanthoshGujulvajagadeesh merged 1 commit intordkcentral:developfrom May 6, 2026
Merged
XF10-696: Correct MAC address format on agent side#65SanthoshGujulvajagadeesh merged 1 commit intordkcentral:developfrom
SanthoshGujulvajagadeesh merged 1 commit intordkcentral:developfrom
Conversation
Reason for change: Device details were not displayed correctly on the Cujo cloud. The root cause was that the MAC address was being sent in a non–colon‑separated format. This change ensures the MAC address is properly formatted before being sent from the agent to the cloud during connection. Test Procedure: - Load the updated image on the device. - Verify that the agent successfully connects to the cloud. - Confirm that device and client details are displayed correctly on the cloud portal. Priority: P1 Risk: Low Signed-off-by: Vysakh A V <vysakh.venugopal@sky.uk>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure the agent sends a correctly formatted (colon-separated) MAC address to the Cujo cloud so device/client details display properly during connection, specifically for the PON_GATEWAY platform path.
Changes:
- Stores the return code from
platform_hal_GetBaseMacAddress()inrcand checks for both success and non-empty output. - Copies the HAL-provided MAC string directly into
deviceMacforPON_GATEWAYbuilds (replacing the prior conversion step).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if ( rc == 0 && deviceMACStr[0] != '\0' ) | ||
| { | ||
| AnscMacToLower(deviceMac, deviceMACStr, sizeof(deviceMac)); | ||
| strcpy_s(deviceMac, sizeof(deviceMac), deviceMACStr); |
Contributor
Author
SanthoshGujulvajagadeesh
approved these changes
May 6, 2026
SanthoshGujulvajagadeesh
merged commit 13d27fc
into
rdkcentral:develop
10 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change:
Device details were not displayed correctly on the Cujo cloud. The root cause was that the MAC address was being sent in a non–colon‑separated format. This change ensures the MAC address is properly formatted before being sent from the agent to the cloud during connection.
Test Procedure:
Priority: P1
Risk: Low
Signed-off-by: Vysakh A V vysakh.venugopal@sky.uk