RDKEMW-13215: dummy2 donotmerge#53
Open
PreethiLakshmi91 wants to merge 2 commits intodevelopfrom
Open
Conversation
Reason for change: Crash and memleak fix - latest Test Procedure: runbook test cases for bluetooth devices Risks: Low Priority: P1 Signed-off-by: ppalan289 <preethi_palanisamy@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR claims to address a Bluetooth crash/memory leak, but the diff only introduces a placeholder comment in the BlueZ5 DBus core interface code.
Changes:
- Added a
//DummyPRcomment inside the paired-device enumeration logic.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (strcmp(dbusObject2, "Paired") == 0 && device_prop) { | ||
| if(adapter_path) | ||
| strncpy(&paths[d][0], adapter_path, (strlen(adapter_path) < BT_MAX_DEV_PATH_LEN) ? strlen(adapter_path) : BT_MAX_DEV_PATH_LEN - 1); | ||
| //DummyPR |
There was a problem hiding this comment.
The added //DummyPR line looks like a placeholder and does not implement the stated crash/memory-leak fix. Please remove this dummy comment (or replace it with an explanatory comment tied to a real behavioral change) so the diff reflects the intended fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Crash and memleak fix - latest
Test Procedure: runbook test cases for bluetooth devices
Risks: Low
Priority: P1