RDKEMW-12176: DonotMerge#61
Open
PreethiLakshmi91 wants to merge 1 commit intordkcentral:developfrom
Open
Conversation
Reason for change: Unit tests failure check Test Procedure: Device deepsleep causing the crash Risks: Low Priority: P2 Signed-off-by: ppalan289 <preethi_palanisamy@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears intended to validate unit-test/CI behavior related to a deepsleep crash, but the only code change is the addition of a placeholder comment, so it doesn’t currently implement or document any functional fix.
Changes:
- Added a single placeholder comment in
btrCore_PopulateListOfPairedDevices().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1507
to
+1508
| /* Initially stBTRCoreKnownDevice List is populated from pstBTPairedDeviceInfo(bluez i/f) directly *********/ | ||
| /* Dummy change */ |
There was a problem hiding this comment.
The added "Dummy change" comment appears to be a placeholder and doesn’t explain any behavior or address the stated crash/test failures. Please remove it, or replace it with a comment that documents a real logic change (and include the actual fix in this PR if one is intended).
Suggested change
| /* Initially stBTRCoreKnownDevice List is populated from pstBTPairedDeviceInfo(bluez i/f) directly *********/ | |
| /* Dummy change */ | |
| /* Initially, when no paired devices are tracked yet, populate stBTRCoreKnownDevice list */ | |
| /* from BlueZ-provided pstBTPairedDeviceInfo and initialize device state accordingly. */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Unit tests failure check
Test Procedure: Device deepsleep causing the crash
Risks: Low
Priority: P2