RDKEMW-14533 : DummyPR-forCovTest#67
Closed
PreethiLakshmi91 wants to merge 1 commit intodevelopfrom
Closed
Conversation
Reason for change: Inclusion of coverity for BT Test Procedure: NA Risks: Low Priority: P2 Signed-off-by: ppalan289 <preethi_palanisamy@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears to be a “dummy” change intended to trigger/validate Coverity integration for the Bluetooth (BT) component, but it introduces a critical memory safety defect in a BT adapter status callback.
Changes:
- Modified the
memsetsize used to initialize a localstBTRCoreAdapterstruct inbtrCore_BTAdapterStatusUpdateCb.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| memset(&lstAdapterInfo, 0, sizeof(stBTRCoreAdapter)); | ||
| memset(&lstAdapterInfo, 0, 10*sizeof(stBTRCoreAdapter)); |
There was a problem hiding this comment.
lstAdapterInfo is a single stBTRCoreAdapter stack variable, but this memset zeros 10 * sizeof(stBTRCoreAdapter) bytes, which will write past the end of the object and corrupt the stack. Use sizeof(lstAdapterInfo) (or sizeof(stBTRCoreAdapter)) for the size argument; multiplying by 10 is unsafe and incorrect here.
Suggested change
| memset(&lstAdapterInfo, 0, 10*sizeof(stBTRCoreAdapter)); | |
| memset(&lstAdapterInfo, 0, sizeof(lstAdapterInfo)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Inclusion of coverity for BT
Test Procedure: NA
Risks: Low
Priority: P2