CMFSUPPORT-3744 Autoupdate manifest#35
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a reusable GitHub Actions workflow intended to auto-update and open PRs for Raspberry Pi-related manifest repositories when a meta-repo PR is merged.
Changes:
- Introduces
auto_pr_creation_rpi_manifests.ymlas aworkflow_callreusable workflow. - Checks out three manifest repos (vendor/middleware/image-assembler) and runs the shared
auto_pr_generation_manifest.pyscript in each.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| with: | ||
| repository: rdkcentral/build_tools_workflows | ||
| path: 'tools' | ||
| ref: develop |
There was a problem hiding this comment.
The workflow checks out rdkcentral/build_tools_workflows using a moving ref (ref: develop). Because this workflow consumes secrets (PAT) and runs code from that repo, pinning to an immutable tag or commit SHA would reduce supply-chain risk and avoid unexpected behavior changes when develop moves.
| ref: develop | |
| ref: <FULL_40_CHARACTER_COMMIT_SHA_FOR_REVIEWED_BUILD_TOOLS_WORKFLOWS_REVISION> |
| - name: Update Git Config | ||
| env: | ||
| BOT_EMAIL: ${{ vars.RDKM_BOT_EMAIL }} | ||
| run: | | ||
| cd vendor_manifest_repo | ||
| git config user.name "bot" | ||
| git config user.email "$BOT_EMAIL" | ||
| cd .. |
There was a problem hiding this comment.
There are three separate "Update Git Config" steps that run the same commands in different directories. Consider setting git config --global user.name/user.email once (or using working-directory:) to reduce duplication and make future changes less error-prone.
| - name: Update Git Config | ||
| env: | ||
| BOT_EMAIL: ${{ vars.RDKM_BOT_EMAIL }} | ||
| run: | | ||
| cd middleware_manifest_repo | ||
| git config user.name "bot" | ||
| git config user.email "$BOT_EMAIL" | ||
| cd .. |
There was a problem hiding this comment.
Multiple steps share the exact same name ("Update Git Config"), which makes the Actions UI logs harder to interpret when troubleshooting. Rename these steps to indicate which repo they apply to (vendor/middleware/image-assembler).
Add github workflows auto_pr_creation_rpi_manifests.yml