RDKEMW-17987: APP_ERROR_FGCrash marker string changed from RDKE 8.3 build#60
RDKEMW-17987: APP_ERROR_FGCrash marker string changed from RDKE 8.3 build#60
Conversation
…uild in core_log file
There was a problem hiding this comment.
Pull request overview
Updates crash telemetry reporting in uploadDumps.sh by changing the marker(s) emitted for container crash information, aligning marker strings/payloads with the desired format.
Changes:
- Replace the combined
APP_ERROR_CrashInfo_accumpayload (containerName, containerStatus) with separate telemetry events for container name and container status. - Adjust logging to emit container name and status as separate log messages.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| logMessage "ContainerName, ContainerStatus = $containerName, $containerStatus" | ||
| t2ValNotify "APP_ERROR_CrashInfo_accum" "$containerName, $containerStatus" | ||
|
|
||
| logMessage "ContainerName = $containerName" |
There was a problem hiding this comment.
Line indentation uses a tab while the surrounding block uses spaces, which makes the formatting inconsistent and can cause noisy diffs. Please align this line’s indentation with the rest of the function.
| logMessage "ContainerName = $containerName" | |
| logMessage "ContainerName = $containerName" |
| logMessage "ContainerName = $containerName" | ||
| t2ValNotify "APP_ERROR_CrashInfo" "$containerName" | ||
| logMessage "ContainerStatus = $containerStatus" | ||
| t2ValNotify "APP_ERROR_CrashInfo_status" "$containerStatus" |
There was a problem hiding this comment.
PR title references changing the APP_ERROR_FGCrash marker string, but this script change modifies APP_ERROR_CrashInfo* markers (and there is no APP_ERROR_FGCrash usage anywhere in the repo). Please confirm the intended marker name(s) and update either the marker strings here or the PR title/metadata so they match the actual change being made.
No description provided.