RDKEMW-17479: Add dump cleanup in legacy script mode for crashupload#62
Open
gomathishankar37 wants to merge 2 commits intodevelopfrom
Open
RDKEMW-17479: Add dump cleanup in legacy script mode for crashupload#62gomathishankar37 wants to merge 2 commits intodevelopfrom
gomathishankar37 wants to merge 2 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the legacy runDumpUpload.sh fallback path to perform the cleanup steps that were previously left disabled as testing placeholders. In the overall codebase, this affects the deprecated shell-based uploader used when the modern crashupload binary is bypassed or unavailable.
Changes:
- Re-enable deletion of the original raw dump after archive creation in the legacy script.
- Re-enable cleanup of
/tmp/uploadtos3paramsafter retry uploads. - Re-enable deletion of the generated archive after upload success/failure in the legacy flow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.