RDKEMW-17695: Standby reboot handling removed#100
RDKEMW-17695: Standby reboot handling removed#100dnnaveen151027 wants to merge 1 commit intosupport/8.4.4.0from
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the middleware OPKG feed configuration used by Yocto/BitBake machine includes, changing the release identifier and the artifact path used to construct middleware IPK feed URLs.
Changes:
- Update
RELEASE_NUMfrom a version string to a ticket ID (RDKEMW-17695). - Switch middleware IPK feed paths from
middleware-rel/...tomiddleware-dbg/...for both standard and OSS middleware feeds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| conf/machine/include/middleware.inc | Changes the middleware feed release identifier and redirects MW_IPK_PATH to middleware-dbg/.... |
| conf/machine/include/oss_mw.inc | Redirects OSS middleware feed path to middleware-dbg/.... |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| RELEASE_NUM = "RDKEMW-17695" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
The PR title/description mentions removing standby reboot handling, but this change updates the middleware artifact/feed location (RELEASE_NUM and MW_IPK_PATH). Please update the PR description to reflect this configuration change (or split into a separate PR) so reviewers can assess the correct risk/impact.
| PACKAGE_EXTRA_ARCHS:append = " ${MIDDLEWARE_ARCH}" | ||
|
|
||
| RELEASE_NUM = "8.4.4.10" | ||
| RELEASE_NUM = "RDKEMW-17695" |
There was a problem hiding this comment.
RELEASE_NUM was previously a version-like value but is now set to a ticket ID ("RDKEMW-17695"). If this variable is intended to represent a middleware release version, consider keeping it as a version string and introducing a separate variable/comment for the ticket; otherwise rename the variable (and any related naming) to avoid misleading future maintenance.
| RELEASE_NUM = "RDKEMW-17695" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
MW_IPK_PATH is switched from "middleware-rel" to "middleware-dbg" unconditionally. If this include is used for production/release builds, this will point opkg feeds at debug artifacts; consider selecting rel vs dbg based on BUILD_VARIANT (or a dedicated feature/override) so release builds don’t consume debug packages.
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_IPK_PATH ?= "${@('middleware-dbg' if d.getVar('BUILD_VARIANT') == 'dbg' else 'middleware-rel')}/${RELEASE_NUM}" |
| PACKAGE_EXTRA_ARCHS:append = " ${MW_OSS} " | ||
| OPKG_ARCH_PRIORITY:${MW_OSS} = "205" | ||
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
MW_OSS_IPK_PATH is switched from "middleware-rel" to "middleware-dbg" unconditionally. If OSS middleware feeds are consumed by non-debug images, this will redirect them to debug artifacts; consider gating this on BUILD_VARIANT or a distro/machine override to avoid unintended debug-package rollout.
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_OSS_IPK_PATH ?= "${@'middleware-dbg/%s' % d.getVar('RELEASE_NUM') if d.getVar('BUILD_VARIANT') == 'debug' else 'middleware-rel/%s' % d.getVar('RELEASE_NUM')}" |
Reason for change: standby reboot handling removed
Test Procedure: refer ticket
Risks: Low
version : minor
Priority: P1
Signed-off-by:Naveen_Dunna Naveen_Dunna@comcast.com