Skip to content

RDK-48642: Moving DeviceProvisioning configuration URLs to the product layers#36

Merged
divyang-public merged 2 commits intodevelopfrom
feature/RDK-48642
Apr 28, 2026
Merged

RDK-48642: Moving DeviceProvisioning configuration URLs to the product layers#36
divyang-public merged 2 commits intodevelopfrom
feature/RDK-48642

Conversation

@sergiygladkyy
Copy link
Copy Markdown
Contributor

@sergiygladkyy sergiygladkyy commented Feb 4, 2026

No description provided.

@sergiygladkyy sergiygladkyy requested a review from a team as a code owner February 4, 2026 20:47
Copilot AI review requested due to automatic review settings February 4, 2026 20:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves DeviceProvisioning configuration URLs to the product layers by introducing a new BitBake class that modifies the socprovisioning.ini file at image assembly time with product-layer-specific values.

Changes:

  • Added new socprovisioning-config.bbclass that stamps /etc/rfcdefaults/socprovisioning.ini with product-layer values
  • Updated image-classes.inc to include the new socprovisioning-config class

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
conf/include/image-classes.inc Adds socprovisioning-config to IMAGE_CLASSES to enable the new configuration class
classes/socprovisioning-config.bbclass New bbclass that modifies socprovisioning.ini file at image build time, replacing specific configuration values from product layer variables

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread classes/socprovisioning-config.bbclass Outdated
Comment thread classes/socprovisioning-config.bbclass Outdated
Comment thread classes/socprovisioning-config.bbclass Outdated
Comment thread classes/socprovisioning-config.bbclass Outdated
Comment thread classes/socprovisioning-config.bbclass
Copilot AI review requested due to automatic review settings February 26, 2026 17:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sergiygladkyy sergiygladkyy force-pushed the feature/RDK-48642 branch 2 times, most recently from f4ac99e to 49769a1 Compare March 9, 2026 17:42
Copilot AI review requested due to automatic review settings March 9, 2026 18:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread classes/socprovisioning-config.bbclass Outdated
Comment thread classes/socprovisioning-config.bbclass Outdated
Comment thread classes/socprovisioning-config.bbclass
@sergiygladkyy sergiygladkyy linked an issue Mar 13, 2026 that may be closed by this pull request
@sergiygladkyy sergiygladkyy linked an issue Apr 3, 2026 that may be closed by this pull request
…t layers

Reason for change: DeviceProvisioning configuration is

Test Procedure: described in the ticket
Implements: recipe changes
Risks: No
Source: COMCAST
License: Apache-2.0
Upstream-Status: Pending
Signed-off-by: Sergiy Gladkyy <sgladkyy@productengine.com>
Copilot AI review requested due to automatic review settings April 9, 2026 18:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread classes/socprovisioning-config.bbclass
Comment thread classes/socprovisioning-config.bbclass
Comment thread classes/socprovisioning-config.bbclass Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 9, 2026 20:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@divyang-public divyang-public merged commit 998ce82 into develop Apr 28, 2026
15 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RDK-48642: CI verification

5 participants