Topic/rdkemw 16060#74
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the middleware OPKG feed configuration to point to a different artifact release identifier and repository path, affecting where middleware IPKs are fetched from during builds.
Changes:
- Updated
RELEASE_NUMfrom a dotted version to a tag-like identifier (RDKEMW-16060). - Switched middleware feed base paths from
middleware-rel/...tomiddleware-dbg/...for both standard and OSS middleware feeds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| conf/machine/include/middleware.inc | Changes the release identifier and redirects the main middleware IPK feed path to middleware-dbg. |
| conf/machine/include/oss_mw.inc | Redirects the OSS middleware IPK feed path to middleware-dbg. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PACKAGE_EXTRA_ARCHS:append = " ${MIDDLEWARE_ARCH}" | ||
|
|
||
| RELEASE_NUM = "8.4.4.8" | ||
| RELEASE_NUM = "RDKEMW-16060" |
There was a problem hiding this comment.
RELEASE_NUM is now set to a non-numeric identifier ("RDKEMW-16060"). If this value is intended to be a ticket/build tag rather than a semantic release number, consider renaming the variable (or introducing a separate variable like RELEASE_TAG/MW_BUILD_ID used in the feed path) to avoid confusion and reduce the risk of downstream consumers assuming a dotted version format.
| RELEASE_NUM = "RDKEMW-16060" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
Changing MW_IPK_PATH from middleware-rel/... to middleware-dbg/... will redirect all consumers of this include to the debug feed. If debug feeds are only intended for specific builds, consider keeping the default as middleware-rel and selecting middleware-dbg via an overridable knob (e.g., a MW_FEED_CHANNEL variable) or by deriving it from an existing build setting, to avoid accidentally shipping debug packages in release images.
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_FEED_CHANNEL ?= "middleware-rel" | |
| MW_IPK_PATH ?= "${MW_FEED_CHANNEL}/${RELEASE_NUM}" |
| PACKAGE_EXTRA_ARCHS:append = " ${MW_OSS} " | ||
| OPKG_ARCH_PRIORITY:${MW_OSS} = "205" | ||
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
MW_OSS_IPK_PATH was switched from middleware-rel/... to middleware-dbg/..., which will redirect OSS middleware package feeds to the debug artifact location. If this should be conditional (e.g., only for debug builds), consider making the base path selectable via an overridable variable (shared with middleware.inc) to avoid affecting all builds that enable STACK_LAYER_OSS_SUPPORT.
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_OSS_IPK_BASE_PATH ?= "middleware-rel" | |
| MW_OSS_IPK_PATH ?= "${MW_OSS_IPK_BASE_PATH}/${RELEASE_NUM}" |
No description provided.