Feature/rdkemw 16166#80
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the middleware IPK feed configuration to point at a specific debug artifact drop associated with RDKEMW-16166v5.
Changes:
- Updates
RELEASE_NUMtoRDKEMW-16166v5. - Redirects middleware and OSS middleware IPK feed paths from release-based locations to a hard-coded debug artifact path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| conf/machine/include/middleware.inc | Changes default middleware feed version/path to a ticket-specific debug artifacts location. |
| conf/machine/include/oss_mw.inc | Changes OSS middleware feed path to the same ticket-specific debug artifacts location. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| RELEASE_NUM = "RDKEMW-16166v5" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/RDKEMW-16166v5" |
There was a problem hiding this comment.
RELEASE_NUM is now effectively unused because MW_IPK_PATH is hard-coded to a specific ticket/version path. Either parameterize the path again (e.g., derive it from RELEASE_NUM) or remove RELEASE_NUM to avoid dead/duplicated configuration that will drift over time.
| MW_IPK_PATH ?= "middleware-dbg/RDKEMW-16166v5" | |
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
| RELEASE_NUM = "RDKEMW-16166v5" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/RDKEMW-16166v5" |
There was a problem hiding this comment.
This change switches the default feed from middleware-rel/${RELEASE_NUM} to a hard-coded middleware-dbg/RDKEMW-16166v5 location. If this is only intended for a specific debug build, consider keeping the release path as the default and gating the debug feed behind a separate variable/feature (or making it an override in a machine/distro config) to avoid unintentionally pulling debug artifacts in normal builds.
| MW_IPK_PATH ?= "middleware-dbg/RDKEMW-16166v5" | |
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" |
| PACKAGE_EXTRA_ARCHS:append = " ${MW_OSS} " | ||
| OPKG_ARCH_PRIORITY:${MW_OSS} = "205" | ||
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_OSS_IPK_PATH ?= "middleware-dbg/RDKEMW-16166v5" |
There was a problem hiding this comment.
MW_OSS_IPK_PATH is hard-coded to the same ticket-specific debug path as MW_IPK_PATH in middleware.inc, which duplicates configuration and risks the two diverging. Consider deriving MW_OSS_IPK_PATH from a shared variable (e.g., MW_IPK_PATH/RELEASE_NUM) so OSS and non-OSS feeds stay consistent.
| MW_OSS_IPK_PATH ?= "middleware-dbg/RDKEMW-16166v5" | |
| MW_OSS_IPK_PATH ?= "${MW_IPK_PATH}" |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.