RDKEMW-17011: metaChanges-donotomerge#86
RDKEMW-17011: metaChanges-donotomerge#86PreethiLakshmi91 wants to merge 1 commit intosupport/8.4.4.0from
Conversation
Reason for change: message_filter is using wrong list to traverse Test Procedure: Risks: Low Priority: P1 Signed-off-by: ppalan289 <preethi_palanisamy@comcast.com>
There was a problem hiding this comment.
Pull request overview
Updates the Yocto machine include configuration that defines the middleware OPKG/IPK feed URL components, changing the default artifact “release” location and release identifier used to construct feed URIs.
Changes:
- Update
RELEASE_NUMto a ticket/build identifier. - Switch middleware IPK feed paths from
middleware-rel/...tomiddleware-dbg/...for both standard and OSS middleware feeds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| conf/machine/include/middleware.inc | Changes RELEASE_NUM and the default MW_IPK_PATH used to build middleware feed URIs. |
| conf/machine/include/oss_mw.inc | Changes the OSS middleware feed path (MW_OSS_IPK_PATH) used to build OSS feed URIs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| RELEASE_NUM = "RDKEMW-17011_MTC2" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
This changes the default middleware feed path from "middleware-rel/${RELEASE_NUM}" to "middleware-dbg/${RELEASE_NUM}", so all consumers of this include will start pulling packages from the debug artifact location. If debug feeds are only intended for specific builds/tests, consider keeping the default on the release feed and selecting the debug path via an override/feature (e.g., a dedicated variable, MACHINE/BUILD_VARIANT override, or local.conf) to avoid impacting production builds.
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_IPK_FEED_TYPE ?= "rel" | |
| MW_IPK_PATH ?= "middleware-${MW_IPK_FEED_TYPE}/${RELEASE_NUM}" |
| PACKAGE_EXTRA_ARCHS:append = " ${MW_OSS} " | ||
| OPKG_ARCH_PRIORITY:${MW_OSS} = "205" | ||
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
This switches MW_OSS_IPK_PATH to use the "middleware-dbg/${RELEASE_NUM}" location. Since this affects the OSS middleware feed URI, it will change where opkg resolves packages from. If the intention is to use release artifacts by default, keep "middleware-rel" here and gate the debug path behind an explicit override/feature so normal builds don't change feeds unexpectedly.
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" |
| PACKAGE_EXTRA_ARCHS:append = " ${MIDDLEWARE_ARCH}" | ||
|
|
||
| RELEASE_NUM = "8.4.4.9" | ||
| RELEASE_NUM = "RDKEMW-17011_MTC2" |
There was a problem hiding this comment.
RELEASE_NUM is being changed from a version-like value to a ticket/build identifier ("RDKEMW-17011_MTC2"). If this is meant to be a temporary test feed, consider moving it to a more specific variable (or making RELEASE_NUM a default with '?=' and overriding per build) so the include remains stable and doesn't encode a one-off identifier in the shared config.
| RELEASE_NUM = "RDKEMW-17011_MTC2" | |
| RELEASE_NUM ?= "RDKEMW-17011_MTC2" |
| RELEASE_NUM = "RDKEMW-17011_MTC2" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
The PR description mentions a message_filter list traversal issue, but this change only updates middleware IPK feed configuration (RELEASE_NUM and *IPK_PATH). Please update the PR description (or the code changes) so they match; otherwise it's hard to validate risk/intent for this change.
Reason for change: message_filter is using wrong list to traverse Test Procedure:
Risks: Low
Priority: P1