RDKEMW-17011: metaChanges-donotomerge-fork#87
RDKEMW-17011: metaChanges-donotomerge-fork#87PreethiLakshmi91 wants to merge 1 commit intordkcentral:support/8.4.4.0from
Conversation
Reason for change: message_filter is using wrong list to traverse Test Procedure: Risks: Low Priority: P1 Signed-off-by: ppalan289 <preethi_palanisamy@comcast.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the BitBake middleware IPK feed configuration used by machines to construct IPK_FEED_URIS, changing both the release identifier and the artifact namespace used for middleware package retrieval.
Changes:
- Update
RELEASE_NUMto a ticket/build identifier (RDKEMW-17011_17A1). - Switch middleware and OSS middleware feed paths from
middleware-rel/...tomiddleware-dbg/....
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| conf/machine/include/middleware.inc | Changes the default middleware feed release label and points the feed path to middleware-dbg. |
| conf/machine/include/oss_mw.inc | Points the OSS middleware feed path to middleware-dbg as well. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| RELEASE_NUM = "RDKEMW-17011_17A1" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | ||
| MW_IPK_SERVER_PATH ?= "${RDK_ARTIFACTS_BASE_URL}/${MW_IPK_PATH}/${RDK_MW_ARCH}/ipks/${BUILD_VARIANT}" |
There was a problem hiding this comment.
The PR description mentions fixing message_filter traversal logic, but this diff only changes middleware artifact feed configuration (RELEASE_NUM / MW_IPK_PATH). Please update the PR description (and/or title) to match the actual change, or include the missing message_filter fix in this PR so reviewers can validate the intended behavior.
| RELEASE_NUM = "RDKEMW-17011_17A1" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
This change switches the default middleware IPK feed from middleware-rel/... to middleware-dbg/... unconditionally. If this include is used for production/release builds, this can cause devices/builds to pull debug artifacts (or fail to resolve packages if the middleware-dbg feed is not published). Consider keeping middleware-rel as the default and making middleware-dbg opt-in via a build variable/feature flag (or conditional on BUILD_VARIANT).
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_IPK_FEED_TYPE ?= "rel" | |
| MW_IPK_PATH ?= "middleware-${MW_IPK_FEED_TYPE}/${RELEASE_NUM}" |
| PACKAGE_EXTRA_ARCHS:append = " ${MW_OSS} " | ||
| OPKG_ARCH_PRIORITY:${MW_OSS} = "205" | ||
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
Switching MW_OSS_IPK_PATH to middleware-dbg/${RELEASE_NUM} changes the OSS middleware feed to a debug namespace as well. If the intention is only to debug a specific build, consider making this path override scoped/conditional (e.g., only when a debug feature is enabled) to avoid impacting all consumers of this include.
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_OSS_USE_DEBUG_FEED ?= "0" | |
| MW_OSS_IPK_PATH ?= "${@oe.utils.conditional('MW_OSS_USE_DEBUG_FEED', '1', 'middleware-dbg/${RELEASE_NUM}', 'middleware/${RELEASE_NUM}', d)}" |
| PACKAGE_EXTRA_ARCHS:append = " ${MIDDLEWARE_ARCH}" | ||
|
|
||
| RELEASE_NUM = "8.4.4.5" | ||
| RELEASE_NUM = "RDKEMW-17011_17A1" |
There was a problem hiding this comment.
RELEASE_NUM is being set to a ticket/build identifier (RDKEMW-17011_17A1) rather than a release-like version. Since this value becomes part of the feed URL, hardcoding a per-PR identifier here can make future updates error-prone and can unexpectedly retarget everyone to a one-off artifact set. Consider making RELEASE_NUM configurable (e.g., ?= with a stable default) and overriding it in a machine/local config for this specific build label.
| RELEASE_NUM = "RDKEMW-17011_17A1" | |
| RELEASE_NUM ?= "1.0.0" |
Reason for change: message_filter is using wrong list to traverse
Test Procedure:
Risks: Low
Priority: P1