RDKEMW-17085 : MW feed for support/8.5.3.0#88
RDKEMW-17085 : MW feed for support/8.5.3.0#88aktamilbe wants to merge 1 commit intosupport/8.5.3.0from
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the middleware OPKG feed configuration for the support/8.5.3.0 line by changing the release identifier and the base artifact feed paths.
Changes:
- Update
RELEASE_NUMused to construct middleware feed URLs. - Switch middleware and OSS middleware IPK feed base paths from
middleware-rel/...tomiddleware-dbg/....
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| conf/machine/include/middleware.inc | Changes the release identifier and middleware feed base path used to build IPK_FEED_URIS. |
| conf/machine/include/oss_mw.inc | Changes the OSS middleware feed base path used to build IPK_FEED_URIS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| RELEASE_NUM = "RDKEMW-17085" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
PR title indicates this change is for support/8.5.3.0, but RELEASE_NUM is now set to "RDKEMW-17085". Since RELEASE_NUM is used to construct the feed URL path, this will redirect clients to a different artifacts location than 8.5.3.0. Please align RELEASE_NUM with the intended release identifier (or update the PR title/branch intent if the ticket ID is the correct directory name).
| RELEASE_NUM = "RDKEMW-17085" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
MW_IPK_PATH was switched from "middleware-rel/${RELEASE_NUM}" to "middleware-dbg/${RELEASE_NUM}". This changes the base feed location and may cause production builds to consume debug-only artifacts (or fail to resolve packages) depending on how the artifact repository is structured. If the intent is to use release artifacts for a support branch, keep the "middleware-rel" path (or make the dbg/rel selection depend on BUILD_VARIANT to avoid hard-coding debug).
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_IPK_PATH ?= "${@('middleware-dbg' if d.getVar('BUILD_VARIANT') == 'dbg' else 'middleware-rel')}/${RELEASE_NUM}" |
| PACKAGE_EXTRA_ARCHS:append = " ${MW_OSS} " | ||
| OPKG_ARCH_PRIORITY:${MW_OSS} = "205" | ||
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
MW_OSS_IPK_PATH was changed from "middleware-rel/${RELEASE_NUM}" to "middleware-dbg/${RELEASE_NUM}", which will redirect the OSS feed to a debug artifacts location. If this feed is consumed in non-debug builds, this can lead to missing/incorrect packages; consider keeping the release path or tying the dbg/rel prefix to BUILD_VARIANT (consistent with how the server path already includes ${BUILD_VARIANT}).
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_OSS_IPK_PATH ?= "${@'middleware-dbg/%s' % d.getVar('RELEASE_NUM') if (d.getVar('BUILD_VARIANT') or '').lower() in ('dbg', 'debug') else 'middleware-rel/%s' % d.getVar('RELEASE_NUM')}" |
No description provided.