DELIA-70321 : Apparmor Permissions denied for tr69hostif#91
DELIA-70321 : Apparmor Permissions denied for tr69hostif#91madhubabutt wants to merge 1 commit intosupport/8.4.4.0from
Conversation
There was a problem hiding this comment.
Pull request overview
Updates middleware IPK feed configuration to pull artifacts from a different server path and identifies a different artifact “release” folder.
Changes:
- Switches middleware and OSS middleware IPK feed paths from
middleware-rel/...tomiddleware-dbg/.... - Replaces the
RELEASE_NUMvalue withDELIA-70321(ticket ID) for feed path construction.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| conf/machine/include/middleware.inc | Changes RELEASE_NUM and defaults middleware feed to middleware-dbg/${RELEASE_NUM}. |
| conf/machine/include/oss_mw.inc | Changes OSS middleware feed default path to middleware-dbg/${RELEASE_NUM}. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PACKAGE_EXTRA_ARCHS:append = " ${MW_OSS} " | ||
| OPKG_ARCH_PRIORITY:${MW_OSS} = "205" | ||
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
MW_OSS_IPK_PATH is also being switched to middleware-dbg/..., meaning OSS-layer feeds will default to debug artifacts as well. If this is only needed temporarily for a specific investigation/build, consider making it opt-in (override/feature flag) so production builds keep using the release feed by default.
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_OSS_IPK_PATH ?= "middleware/${RELEASE_NUM}" |
| PACKAGE_EXTRA_ARCHS:append = " ${MIDDLEWARE_ARCH}" | ||
|
|
||
| RELEASE_NUM = "8.4.4.10" | ||
| RELEASE_NUM = "DELIA-70321" |
There was a problem hiding this comment.
RELEASE_NUM is being changed from a version-like identifier to a ticket ID ("DELIA-70321") and is still assigned with = (hard override). This will affect all builds that include this file and likely break artifact path expectations. Consider keeping RELEASE_NUM as an actual release/version and introducing a separate variable for ad-hoc artifact folders, or make this a weak default (?=) that can be overridden per build config.
| RELEASE_NUM = "DELIA-70321" | |
| RELEASE_NUM ?= "DELIA-70321" |
| RELEASE_NUM = "DELIA-70321" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
MW_IPK_PATH is now defaulting to middleware-dbg/... instead of middleware-rel/..., which will make the build pull debug middleware feeds unless every consumer overrides this variable. If the intent is to use debug feeds only for specific builds, gate this behind an explicit flag/feature (or use BUILD_VARIANT/distro overrides) rather than changing the global default.
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_USE_DEBUG_FEED ?= "0" | |
| MW_IPK_PATH ?= "${@('middleware-dbg/' if d.getVar('MW_USE_DEBUG_FEED') == '1' else 'middleware-rel/') + d.getVar('RELEASE_NUM')}" |
| RELEASE_NUM = "DELIA-70321" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | ||
| MW_IPK_SERVER_PATH ?= "${RDK_ARTIFACTS_BASE_URL}/${MW_IPK_PATH}/${RDK_MW_ARCH}/ipks/${BUILD_VARIANT}" |
There was a problem hiding this comment.
This PR title references AppArmor permission denials for tr69hostif, but the changes here only adjust middleware feed paths and the RELEASE_NUM value. If the intention is to fix an AppArmor issue, the PR description/code should include (or reference) the AppArmor policy changes; otherwise consider retitling/re-scoping the PR to reflect that it is switching to a debug middleware feed for a specific artifact drop.
madhubabutt
force-pushed
the
feature/DELIA-70321
branch
from
3430f1e to
4ab320d
Compare
No description provided.