RDKEMW-17315,RDKEMW-17330: ctrlm hotfix release 1.1.7.2 test builds only#95
RDKEMW-17315,RDKEMW-17330: ctrlm hotfix release 1.1.7.2 test builds only#95klu339 wants to merge 2 commits intosupport/8.4.4.0from
Conversation
klu339
changed the title
klu339
changed the title
There was a problem hiding this comment.
Pull request overview
Updates the middleware IPK feed configuration to point at a new artifact “release” identifier and directory structure for the ctrlm hotfix.
Changes:
- Updates
RELEASE_NUMfrom a numeric version toRDKEMW-17315. - Switches middleware and OSS middleware feed roots from
middleware-rel/...tomiddleware-dbg/....
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| conf/machine/include/middleware.inc | Changes the release identifier and the base IPK feed path used to construct MW_IPK_SERVER_PATH. |
| conf/machine/include/oss_mw.inc | Updates the OSS middleware IPK feed base path used to construct MW_OSS_IPK_SERVER_PATH. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PACKAGE_EXTRA_ARCHS:append = " ${MIDDLEWARE_ARCH}" | ||
|
|
||
| RELEASE_NUM = "8.4.4.10" | ||
| RELEASE_NUM = "RDKEMW-17315" |
There was a problem hiding this comment.
RELEASE_NUM was previously a numeric version (e.g., 8.4.4.10 in the removed line) but is now set to a Jira ticket (RDKEMW-17315). Given the PR title indicates a release hotfix version (1.1.7.1), this makes the meaning of RELEASE_NUM ambiguous and may confuse tooling/consumers that treat it as a version. Consider using the actual release version here (or introducing a separate variable like an artifact/tag identifier if the directory is keyed by Jira ID).
| RELEASE_NUM = "RDKEMW-17315" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
This switches the feed root from middleware-rel/... to middleware-dbg/.... With the PR being a "release hotfix", consuming debug IPKs here would be a major behavior change (and could unintentionally pull debug builds into release images). Please confirm the artifact layout and, if the intent is a release feed, keep this as middleware-rel/${RELEASE_NUM} (or make the rel/dbg choice depend on ${BUILD_VARIANT} rather than hard-coding dbg).
| PACKAGE_EXTRA_ARCHS:append = " ${MW_OSS} " | ||
| OPKG_ARCH_PRIORITY:${MW_OSS} = "205" | ||
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
This switches OSS middleware IPK consumption from middleware-rel/... to middleware-dbg/.... If this layer is meant to be used for a release hotfix, pointing the OSS feed at debug artifacts is a high-risk change; please verify the server directory structure and ensure the rel/dbg selection is intentional (ideally driven by ${BUILD_VARIANT} rather than hard-coded).
klu339
changed the title
klu339
changed the title
No description provided.