Rebase with develop by AravindanNC · Pull Request #185 · rdkcentral/meta-rdk-oss-reference

AravindanNC · 2025-08-20T14:36:55Z

No description provided.

Reason for change: Bring in wipefs and blkdiscard as they are required for few platforms while performing factory reset. Also update "util-linux-" to ${PN} to support the MLPREFIX as well. Signed-off-by: Arjun <arjun_daasuramdass@comcast.com> Co-authored-by: maniselva006c <mani.sselvaraj@gmail.com>

Reason for the change: Add missing iptable packages required for rdk platform

Reason for change: Update the util-linux package revision

Reason for change: Update packagegroup revision to reflect new version Signed-off-by: mselva006c <mani_selvaraj@comcast.com>

Reason for change: Update change log for 4.7.1 release Signed-off-by: mselva006c <mani_selvaraj@comcast.com>

Reason for change: update rdkperf version from git to 1.0.0

Reason for change: Add deviceType RFC check before launching dropbear Test Procedure: Flash the build , ssh and verify Risks: High Priority: P1 --------- Signed-off-by: nm296 <nareshkumar_m@comcast.com> Co-authored-by: nm296 <nareshkumar_m@comcast.com> Co-authored-by: maniselva006c <mani.sselvaraj@gmail.com>

Reason for change: Porting CVE patches for libarchive and libxml2 --------- Co-authored-by: skondu363 <Srihariraghava_konduritirumala@comcast.com> Co-authored-by: maniselva006c <mani.sselvaraj@gmail.com>

Reason for change: Updated release version Signed-off-by: mselva006c <mani_selvaraj@comcast.com> Co-authored-by: mselva006c <mani_selvaraj@comcast.com>

Reason for change: Update change log for release 4.8.0 Signed-off-by: mselva006c <mani_selvaraj@comcast.com>

Release 4.8.0

REBASE with 4.7.1

Change-Id: Ia71c053cbca6c3f455fd1be71c76bc519a2cbb45

…No User Impact] (#184) Reason for the change: Resolved the crash by applying the upstream patch - https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1791

CLAassistant · 2025-08-20T14:37:04Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
15 out of 16 committers have signed the CLA.

✅ Arjun-DR
✅ NareshM1702
✅ h1712
✅ maniselva006c
✅ dayachristudasan
✅ AravindanNC
✅ simi-mathew
✅ shahin217
✅ KTirumalaSrihari
✅ Vismalskumar0
✅ emutavchi
✅ nrajan002c
✅ tharun-kumarv
✅ Lasya-Prakarsha-D-V
✅ Alan-Ryan
❌ mselva006c

mselva006c seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

* RDKOSS-451: Update logrotate-update-service-files.patch * RDKOSS-451: Create fix_fd_leak.patch * RDKOSS-451: Update logrotate_3.21.0.bbappend * RDKOSS-451: Update logrotate package_revisions_oss.inc * RDKOSS-451: Change logrotate to systemd timer logic Remove daemon patch --------- Co-authored-by: maniselva006c <mani.sselvaraj@gmail.com>

Rebase with develop

RDKOSS-510: Add ptest support

Reason for the change: Fix the cairo build error due the version update triggered from meta-lts-mixin layer Signed-off-by: mselva006c <mani_selvaraj@comcast.com> Co-authored-by: mselva006c <mani_selvaraj@comcast.com>

Copilot

Pull request overview

Copilot reviewed 222 out of 322 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (4)

recipes-multimedia/gstreamer/gstreamer1.0_1.18/files/0001-Fix-leak-of-protection-event-value-objects.patch:1

gst_value_list_append_and_take_value() takes ownership of the passed GValue* and expects it to remain valid beyond the call (the previous code heap-allocated the GValue). Passing the address of a stack GValue risks use-after-free / invalid free. Use gst_value_list_append_value(&event_list, &event_value) and then g_value_unset(&event_value), or keep heap allocation and ensure the list takes ownership correctly.

From 94c5a97d3cdd5f7d49abc3add71d687eb805ef05 Mon Sep 17 00:00:00 2001

recipes-extended/libmanette/libmanette/0001-nintendo-digital-trigger-dpad-fix.patch:1

BTN_TL2/BTN_TR2 are key (EV_KEY) codes, not absolute axis (EV_ABS) codes. Checking them via has_abs() will always be wrong, which can misclassify devices and break trigger handling. Use has_key(device, BTN_TL2) / has_key(device, BTN_TR2) (and keep has_abs() checks only for ABS_*).

From 7278b03e84fb57395c74841bc644e6cf85bd1856 Mon Sep 17 00:00:00 2001

recipes-extended/libmanette/libmanette/0001-nintendo-digital-trigger-dpad-fix.patch:1

This change drops the hat index ((code - ABS_HAT0X) / 2) and leaves only the axis-in-pair (% 2), so multiple hats (HAT0/HAT1/...) will collide and be indistinguishable. If the goal is to avoid key_map corruption from a specific key value, keep the original hat indexing logic and address the underlying key_map issue (e.g., bounds/normalization) rather than discarding hat identity.

From 7278b03e84fb57395c74841bc644e6cf85bd1856 Mon Sep 17 00:00:00 2001

recipes-core/glib-networking/glib-networking/handle_ZERO_RETURN_as_closed_connection.patch:1

SSL_ERROR_ZERO_RETURN indicates the peer sent close_notify (orderly TLS shutdown). In that case, SSL_get_shutdown() is expected to be non-zero, so this change will report a normal TLS close as an unexpected connection error. The condition should be inverted (treat missing shutdown/notify as unexpected), or the behavior should map to an EOF/closed condition rather than an error.

diff --git a/tls/openssl/gtlsconnection-openssl.c b/tls/openssl/gtlsconnection-openssl.c

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-02T18:26:56Z

+set -o pipefail
+


set -o pipefail is not guaranteed to be supported by /bin/sh on all target systems (it commonly fails on strictly POSIX shells). Either change the shebang to #!/bin/bash (and ensure bash is in RDEPENDS for the ptest package) or make pipefail conditional / remove it.

Suggested change

set -o pipefail

Copilot · 2026-04-02T18:26:56Z

+        continue
+    fi
+
+    timeout 60 bash "$test_script" > /dev/null 2>&1


Line 22 uses [ ! -name \"*.sh\" ], which is not valid test syntax and will always error/behave incorrectly. Also, the loop includes non-shell executable binaries (-perm -u+x) but always runs them via bash, which will fail. Split handling into: (1) run bash only for *.sh, and (2) execute binaries directly; use a case on the filename instead of trying to test -name inside [ ... ].

Copilot · 2026-04-02T18:26:57Z

@@ -0,0 +1,5 @@
+#!/bin/sh
+
+workdir=$(dirname `realpath $0`)


realpath may not be present in minimal images, which can cause ptest to fail at startup. Prefer readlink -f (commonly available) or avoid external dependencies by using workdir=$(CDPATH= cd -- \"$(dirname -- \"$0\")\" && pwd).

Suggested change

workdir=$(dirname `realpath $0`)

workdir=$(CDPATH= cd -- "$(dirname -- "$0")" && pwd)

Copilot · 2026-04-02T18:26:57Z

+PASS_COUNT=0
+FAIL_COUNT=0
+SKIP_COUNT=0


FAIL_COUNT is never incremented and any mismatch is treated as SKIP, even when it may indicate a real regression. Consider distinguishing feature-missing cases (skip) from genuine assertion failures (fail), and increment FAIL_COUNT accordingly so ptest results can be trusted.

Copilot · 2026-04-02T18:26:57Z

+        # Treat as SKIP - likely missing kernel modules (ip6_tables, nat, mangle, etc.)
+        echo "SKIP: $test_name (expected $rc_spec got $rc_got)"
+        SKIP_COUNT=$((SKIP_COUNT + 1))


FAIL_COUNT is never incremented and any mismatch is treated as SKIP, even when it may indicate a real regression. Consider distinguishing feature-missing cases (skip) from genuine assertion failures (fail), and increment FAIL_COUNT accordingly so ptest results can be trusted.

Suggested change

# Treat as SKIP - likely missing kernel modules (ip6_tables, nat, mangle, etc.)

echo "SKIP: $test_name (expected $rc_spec got $rc_got)"

SKIP_COUNT=$((SKIP_COUNT + 1))

echo "FAIL: $test_name (expected $rc_spec got $rc_got)"

FAIL_COUNT=$((FAIL_COUNT + 1))

Update CODEOWNERS

Copilot

Pull request overview

Copilot reviewed 222 out of 322 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

recipes-multimedia/gstreamer/gstreamer1.0_1.18/files/0001-Fix-leak-of-protection-event-value-objects.patch:1

gst_value_list_append_and_take_value() takes ownership of the passed GValue container (commonly heap-allocated) and may free it after appending. Passing the address of a stack-allocated GValue (event_value) risks freeing stack memory / UAF. Use the non-“take” API (append without taking ownership) when using stack storage, or keep heap allocation and ensure the callee ownership contract matches.

From 94c5a97d3cdd5f7d49abc3add71d687eb805ef05 Mon Sep 17 00:00:00 2001

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-16T14:30:59Z

+ gst/playback/gstdecodebin3.c | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/gst/playback/gstdecodebin3.c b/gst/playback/gstdecodebin3.c
+index f2614a4..9388978 100644
+--- a/gst/playback/gstdecodebin3.c
+++ b/gst/playback/gstdecodebin3.c
+@@ -654,6 +654,8 @@ gst_decodebin3_dispose (GObject * object)
+   g_list_free (dbin->to_activate);
+   g_list_free (dbin->pending_select_streams);
+   g_clear_object (&dbin->collection);
+  if (dbin->caps)
+    gst_caps_unref (dbin->caps);


In a dispose() implementation, unref’ing without clearing the pointer can lead to a double-unref if dispose() is called multiple times during object finalization. Prefer clearing the member (e.g., unref + set to NULL, or use the framework helper that clears and unrefs).

Suggested change

gst/playback/gstdecodebin3.c | 2 ++

1 file changed, 2 insertions(+)

diff --git a/gst/playback/gstdecodebin3.c b/gst/playback/gstdecodebin3.c

index f2614a4..9388978 100644

--- a/gst/playback/gstdecodebin3.c

+++ b/gst/playback/gstdecodebin3.c

@@ -654,6 +654,8 @@ gst_decodebin3_dispose (GObject * object)

g_list_free (dbin->to_activate);

g_list_free (dbin->pending_select_streams);

g_clear_object (&dbin->collection);

+ if (dbin->caps)

+ gst_caps_unref (dbin->caps);

gst/playback/gstdecodebin3.c | 1 +

1 file changed, 1 insertion(+)

diff --git a/gst/playback/gstdecodebin3.c b/gst/playback/gstdecodebin3.c

index f2614a4..9388978 100644

--- a/gst/playback/gstdecodebin3.c

+++ b/gst/playback/gstdecodebin3.c

@@ -654,6 +654,7 @@ gst_decodebin3_dispose (GObject * object)

g_list_free (dbin->to_activate);

g_list_free (dbin->pending_select_streams);

g_clear_object (&dbin->collection);

+ gst_clear_caps (&dbin->caps);

Copilot · 2026-04-16T14:31:00Z


 inherit meson pkgconfig gobject-introspection ptest vala

+PACKAGECONFIG:append = "wayland-inputfd"


PACKAGECONFIG:append should include a leading space, otherwise it concatenates directly onto the existing value and can produce an invalid token (e.g., "...foo" + "wayland-inputfd" → "...foowayland-inputfd"). Use a space-prefixed append string (or PACKAGECONFIG:append = " wayland-inputfd").

Suggested change

PACKAGECONFIG:append = "wayland-inputfd"

PACKAGECONFIG:append = " wayland-inputfd"

Copilot · 2026-04-16T14:31:00Z

+     has_abs (device, ABS_GAS) ||
+     has_abs (device, ABS_BRAKE);
+
+  g_print("manet-debug: device: %s is gamecontroller=%s\n",libevdev_get_name (device), has_joystick_axes_or_buttons?"Y":"N" );


This adds unconditional stdout logging in a library code path that can be hit during device probing. That can spam logs and impact performance/boot noise in production images. Consider using g_debug() (respecting GLib log levels), gating behind a debug/trace macro, or removing after validation.

Copilot · 2026-04-16T14:31:00Z

+workdir=$(dirname `realpath $0`)
+cd ${workdir}/testing


This uses legacy backticks and unquoted $0/${workdir}, and relies on realpath being available in the runtime image. Prefer a more portable approach (e.g., readlink -f if available in your base, quoted variables, and cd ... || exit 1) to avoid failures with spaces in paths or minimal userlands.

Suggested change

workdir=$(dirname `realpath $0`)

cd ${workdir}/testing

script_path="$0"

if command -v readlink >/dev/null 2>&1; then

resolved_path=$(readlink -f "$script_path" 2>/dev/null)

if [ -n "$resolved_path" ]; then

script_path="$resolved_path"

fi

fi

workdir=$(dirname -- "$script_path")

cd "${workdir}/testing" || exit 1

Copilot · 2026-04-16T14:31:01Z

+HOMEPAGE = "http://pupnp.sourceforge.net/"
+
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://COPYING;md5=d41d8cd98f00b204e9800998ecf8427e"


d41d8cd... is the MD5 of an empty file. Unless COPYING is actually empty, this checksum is likely incorrect and will cause BitBake to fail license checksum verification. Update it to the real checksum of COPYING in the fetched source tarball.

Suggested change

LIC_FILES_CHKSUM = "file://COPYING;md5=d41d8cd98f00b204e9800998ecf8427e"

LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/BSD-3-Clause;md5=3775480a712fc46a69647678acb234cb"

h1712 and others added 24 commits June 30, 2025 06:20

RDKOSS_128-test: remove unmapped binaries

a67e639

Update libcroco_%.bbappend

abfa500

Update zstd_%.bbappend

bdc954c

Update libpcre_8.39.bb

1003850

Update libpcre_8.39.bb

b278d09

Delete recipes-extended/zstd directory

1642cd4

RDKTV-37484: Add libraries required for iptables service (#145)

3c49db2

Reason for the change: Add missing iptable packages required for rdk platform

RDKEVD-2071: wipefs and blkdiscard are required (#149)

519cd82

Reason for change: Update the util-linux package revision

RDKTV-37484: Add libraries required for iptables service (#150)

9f4d3c4

Reason for change: Update the util-linux package revision

RDKE-872: Updated Packagegroup revision to 4.7.1

b947128

Reason for change: Update packagegroup revision to reflect new version Signed-off-by: mselva006c <mani_selvaraj@comcast.com>

RDKE-872: Update change log for 4.7.1 release

74ac43d

Reason for change: Update change log for 4.7.1 release Signed-off-by: mselva006c <mani_selvaraj@comcast.com>

Merge branch 'hotfix/4.7.1' into support/4.7.0

9a11299

Deploy cla action

353a8a0

RDKOSS-420: Update rdkperf version (#167)

3c8fe33

Reason for change: update rdkperf version from git to 1.0.0

RDK-58081 : Porting RDK-57842 CVE patches to RDK-E (#121)

c0bfe3a

Reason for change: Porting CVE patches for libarchive and libxml2 --------- Co-authored-by: skondu363 <Srihariraghava_konduritirumala@comcast.com> Co-authored-by: maniselva006c <mani.sselvaraj@gmail.com>

RDKE-849: OSS release 4.8.0

be0d7d2

Reason for change: Updated release version Signed-off-by: mselva006c <mani_selvaraj@comcast.com> Co-authored-by: mselva006c <mani_selvaraj@comcast.com>

RDKE-849: Update change log for rel 4.8.0

5ea011f

Reason for change: Update change log for release 4.8.0 Signed-off-by: mselva006c <mani_selvaraj@comcast.com>

Merge branch 'release/4.8.0' into main

19003e0

Merge tag '4.8.0' into develop

84295d8

Release 4.8.0

Merge pull request #174 from rdkcentral/feature/RDKOSS-128-rebase

25f711d

REBASE with 4.7.1

RDKOSS-382, RDKOSS-383 Remove unused binaries

97586fe

Change-Id: Ia71c053cbca6c3f455fd1be71c76bc519a2cbb45

RDKEMW-6121: NetworkManager Daemon Process crashed post reboot test […

787ea26

…No User Impact] (#184) Reason for the change: Resolved the crash by applying the upstream patch - https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1791

AravindanNC requested review from a team August 20, 2025 14:36

AravindanNC and others added 3 commits August 22, 2025 11:33

Update package_revisions_oss.inc

de90dcd

Delete recipes-support/libcroco/libcroco_%.bbappend

1fe9e85

h1712 and others added 22 commits March 23, 2026 12:12

Create liburcu_%.bbappend

437cf23

Create run-ptest

13fcaf8

Create run-ptest

d5ca609

Create binutils_%.bbappend

02510ec

Create run-ptest

f7f0c83

Create libxcrypt_%.bbappend

05bfa08

Update run-ptest

113e877

Create ncurses_%.bbappend

5cbe3f0

Create run-ptest

f47b8dc

Create dtc_%.bbappend

e5d5652

Create run-ptest

378d611

Create psmisc_%.bbappend

0340777

Create run-ptest

4e7bafd

Create libtool_%.bbappend

c9ceed9

Create run-ptest

18d7130

Update package_revisions_oss.inc

ae85acf

Update libarchive_%.bbappend

de587e7

Update libarchive_%.bbappend

c525514

Merge pull request #399 from rdkcentral/develop

adafe43

Rebase with develop

Update package_revisions_oss.inc

c63031c

Merge pull request #398 from rdkcentral/feature/RDKOSS-510

6c9a7e3

RDKOSS-510: Add ptest support

RDKOSS-820: Fix cairo librsvg build error (#404)

0b58d5a

Reason for the change: Fix the cairo build error due the version update triggered from meta-lts-mixin layer Signed-off-by: mselva006c <mani_selvaraj@comcast.com> Co-authored-by: mselva006c <mani_selvaraj@comcast.com>

Copilot AI review requested due to automatic review settings April 2, 2026 18:23

Copilot AI reviewed Apr 2, 2026

View reviewed changes

sbarre01 added 4 commits April 16, 2026 14:17

Update CODEOWNERS

53b139c

Merge pull request #409 from rdkcentral/sbarre01-patch-1

fffa356

Update CODEOWNERS

Update CODEOWNERS

095eedf

Merge pull request #410 from rdkcentral/sbarre01-patch-2

18434c2

Update CODEOWNERS

Copilot AI review requested due to automatic review settings April 16, 2026 14:26

Copilot AI reviewed Apr 16, 2026

View reviewed changes

	workdir=$(dirname `realpath $0`)
	workdir=$(CDPATH= cd -- "$(dirname -- "$0")" && pwd)


		inherit meson pkgconfig gobject-introspection ptest vala

		PACKAGECONFIG:append = "wayland-inputfd"

	PACKAGECONFIG:append = "wayland-inputfd"
	PACKAGECONFIG:append = " wayland-inputfd"

-workdir=$(dirname `realpath $0`)
-cd ${workdir}/testing
+script_path="$0"
+if command -v readlink >/dev/null 2>&1; then
+    resolved_path=$(readlink -f "$script_path" 2>/dev/null)
+    if [ -n "$resolved_path" ]; then
+        script_path="$resolved_path"
+    fi
+fi
+workdir=$(dirname -- "$script_path")
+cd "${workdir}/testing" || exit 1

	LIC_FILES_CHKSUM = "file://COPYING;md5=d41d8cd98f00b204e9800998ecf8427e"
	LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/BSD-3-Clause;md5=3775480a712fc46a69647678acb234cb"

Conversation

AravindanNC commented Aug 20, 2025

Uh oh!

CLAassistant commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

CLAassistant commented Aug 20, 2025 •

edited

Loading