RDKOSS-134: Build systemd V250 by maniselva006c · Pull Request #386 · rdkcentral/meta-rdk-oss-reference

maniselva006c · 2026-03-11T18:56:02Z

Reason for the change:
Configured systemd PREFERRED version to 1:250
Backport tar_1.17 recipe which is gplv2 licenced required for building systemd v250 Backport systemd v250 changes for RDKE

Reason for the change: Configured systemd PREFERRED version to 1:250 Backport tar_1.17 recipe which is gplv2 licenced required for building systemd v250 Backport systemd v250 changes for RDKE Signed-off-by: mselva006c <mani_selvaraj@comcast.com>

Copilot

Pull request overview

This PR updates the Yocto layer to support building against systemd v250 in the OSS configuration by pinning the preferred systemd version and adding a GPLv2 tar recipe (1.17) plus related systemd bbappend adjustments.

Changes:

Added a GPL-2.0-only tar_1.17 recipe (with required patches) to satisfy build constraints when GPLv3 components are excluded.
Pinned PREFERRED_VERSION_systemd to 1:250% and added OSS packaging revision metadata for tar.
Updated systemd_250.%.bbappend to include additional patches/feature-conditionals and adjusted timesyncd configuration.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
recipes-extended/tar/tar_1.17.bb	Introduces tar 1.17 recipe and applies required backported patches.
recipes-extended/tar/tar.inc	Adds shared tar build/install logic used by tar recipes.
recipes-extended/tar/tar/0001-lib-argp-parse.c-Fix-compiler-error.patch	Fixes `-Wformat-security` build failure in old tar sources.
recipes-extended/tar/tar-1.17/m4extensions.patch	Autoconf compatibility fix for older tar sources.
recipes-extended/tar/tar-1.17/gcc43build.patch	GCC inline handling fixes for older toolchains.
recipes-extended/tar/tar-1.17/avoid_heap_overflow.patch	Backported CVE fix to avoid a heap overflow.
recipes-core/systemd/systemd_250.%.bbappend	Backports/overrides for systemd 250 builds and configuration adjustments.
conf/include/package_revisions_oss.inc	Pins systemd to 1:250% and adds tar PR/PACKAGE_ARCH entries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-11T19:18:31Z

 BACKPORTS ?= " "

 RRECOMMENDS:${PN} += " \
        util-linux-swaponoff util-linux-losetup \
        util-linux-libmount util-linux-umount \


The recipe removes custom SRC_URI entries for sysctl and USB-mount artifacts, but later in this .bbappend those artifacts are still referenced/used (e.g., install -m 644 ${WORKDIR}/50-portreserv.conf ... in do_install:append:hybrid() and SYSTEMD_SERVICE:${PN} += "usb-mount@.service"). As-is, ${WORKDIR}/50-portreserv.conf and usb-mount@.service won't be available/installed, which is likely to break the do_install task and/or systemd service packaging. Either re-add the needed files to SRC_URI and install them, or remove the dependent install/SYSTEMD_SERVICE/FILES references if this functionality is being dropped.

Copilot · 2026-03-11T19:18:31Z

+        #Journal conf overide
+        sed -i -e 's/.*ForwardToSyslog=.*/#ForwardToSyslog=no/g' ${D}${sysconfdir}/systemd/journald.conf


Spelling: overide should be override in this comment (searchability/consistency).

Copilot · 2026-03-11T19:18:32Z

+
+do_install:append() {
+    if ${@bb.utils.contains('DISTRO_FEATURES', 'syslog-ng', 'false', 'true', d)}; then
+        #Journal conf overide


Spelling: overide should be override in this comment (searchability/consistency).

Suggested change

#Journal conf overide

#Journal conf override

Copilot · 2026-03-11T19:18:32Z

+do_install:append:client() {
+        install -d ${D}/media/tsb
+}
+
+do_install:append:hybrid() {
+        install -d ${D}/media/tsb
+}
+


/media/tsb is already created earlier in this file in do_install:append() (line 38), so these per-variant install -d ${D}/media/tsb blocks are redundant and increase the risk of future drift between variants. Consider removing these duplicate blocks or consolidating /media/tsb directory creation in a single task/variant-specific helper.

Suggested change

do_install:append:client() {

install -d ${D}/media/tsb

}

do_install:append:hybrid() {

install -d ${D}/media/tsb

}

rdkcmf-jenkins · 2026-03-11T20:38:19Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/meta-rdk-oss-reference/386/rdkcentral/meta-rdk-oss-reference
Commit: d2ceacb

Report detail: gist'

rdkcmf-jenkins · 2026-03-11T21:01:41Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/meta-rdk-oss-reference/386/rdkcentral/meta-rdk-oss-reference
Commit: d2ceacb

Report detail: gist'

rdkcmf-jenkins · 2026-03-12T17:12:28Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/meta-rdk-oss-reference/386/rdkcentral/meta-rdk-oss-reference
Commit: d2ceacb

Report detail: gist'

rdkcmf-jenkins · 2026-03-12T17:24:28Z

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

Upvote reason: Cleared
Commit: d2ceacb
'

Reason for the change: Remove reference to default-time-setter.sh script in systemd-timesyncd to fix the build error.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+	#Configure NTP server (time.google.com) in timesyncd.conf
 	if [ -n "${@bb.utils.contains('PACKAGECONFIG', 'timesyncd', 'timesyncd', '', d)}" ]; then
-	   sed -i -e 's/^#NTP=.*/NTP=ntp.ccp.xcal.tv/g' ${D}${sysconfdir}/systemd/timesyncd.conf
+	   sed -i -e 's/^#NTP=.*/NTP=time.google.com/g' ${D}${sysconfdir}/systemd/timesyncd.conf


 do_install:append() {
-	install -d ${D}${sysconfdir}/sysctl.d
 	install -d ${D}${localstatedir}/lib/systemd/coredump
-	install -m 644 ${WORKDIR}/50-coredump.conf ${D}${sysconfdir}/sysctl.d
-	install -m 644 ${WORKDIR}/50-panic.conf ${D}${sysconfdir}/sysctl.d
-	install -m 644 ${WORKDIR}/50-netfilter.conf ${D}${sysconfdir}/sysctl.d
-	install -m 644 ${WORKDIR}/traffic-filter.conf ${D}${sysconfdir}/sysctl.d
-        install -m 644 ${WORKDIR}/protected_regular.conf ${D}${sysconfdir}/sysctl.d
-        mkdir -pv ${D}/usb
-        mkdir -pv ${D}/usb0
-        mkdir -pv ${D}/usb1
-        install -D -m 0644 ${S}/../usb-mount@.service ${D}${systemd_unitdir}/system/usb-mount@.service
-        install -D -m 0755 ${S}/../usb-mount.sh ${D}${sbindir}/usb-mount.sh
-        install -D -m 0644 ${S}/../99-usb-mount.rules ${D}${sysconfdir}/udev/rules.d/99-usb-mount.rules
-        install -D -m 0644 ${S}/../99-usb-mount.rules ${D}${rootlibexecdir}/udev/rules.d/99-usb-mount.rules
        ln -s /dev/null ${D}${sysconfdir}/udev/rules.d/80-net-setup-link.rules


 BACKPORTS ?= " "

 RRECOMMENDS:${PN} += " \
        util-linux-swaponoff util-linux-losetup \
        util-linux-libmount util-linux-umount \
 "

-PACKAGES =+ "${PN}-usb-support"
-
-FILES:${PN}-usb-support = " \
-        /usb \
-        /usb0 \
-        /usb1 \
-        ${systemd_unitdir}/system/usb-mount@.service \
-        ${sbindir}/usb-mount.sh \
-        ${sysconfdir}/udev/rules.d/99-usb-mount.rules \
-        ${rootlibexecdir}/udev/rules.d/99-usb-mount.rules \
-       "
-
 FILES:${PN}:append = " ${datadir}/bash-completion"
-FILES:${PN}:append = " ${sbindir}/usb-mount.sh"



+        sed -i -e 's/.*RuntimeMaxFileSize=.*/RuntimeMaxFileSize=4M/g' ${D}${sysconfdir}/systemd/journald.conf
+        sed -i -e 's/.*SystemMaxFileSize=.*/SystemMaxFileSize=4M/g' ${D}${sysconfdir}/systemd/journald.conf
+    else
+        #Update Journal configuration if syslog-ng is enabled


+
+do_install:append() {
+    if ${@bb.utils.contains('DISTRO_FEATURES', 'syslog-ng', 'false', 'true', d)}; then
+        #Journal conf overide


RDKOSS-134: Build systemd V250

3d8b9e8

Reason for the change: Configured systemd PREFERRED version to 1:250 Backport tar_1.17 recipe which is gplv2 licenced required for building systemd v250 Backport systemd v250 changes for RDKE Signed-off-by: mselva006c <mani_selvaraj@comcast.com>

maniselva006c requested review from a team and Copilot March 11, 2026 18:56

Copilot started reviewing on behalf of maniselva006c March 11, 2026 18:56 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

Comment thread conf/include/package_revisions_oss.inc

Comment thread recipes-core/systemd/systemd_250.%.bbappend Outdated

Update recipes-core/systemd/systemd_250.%.bbappend

d2ceacb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 11, 2026 19:11

Copilot started reviewing on behalf of maniselva006c March 11, 2026 19:11 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

RDKOSS-134: Update systemd_250.%.bbappend

1adc48d

Reason for the change: Remove reference to default-time-setter.sh script in systemd-timesyncd to fix the build error.

Copilot AI review requested due to automatic review settings March 17, 2026 19:20

Copilot started reviewing on behalf of maniselva006c March 17, 2026 19:21 View session

Copilot AI reviewed Mar 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RDKOSS-134: Build systemd V250#386

RDKOSS-134: Build systemd V250#386
maniselva006c wants to merge 3 commits intodevelopfrom
feature/RDKOSS-134

maniselva006c commented Mar 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

rdkcmf-jenkins commented Mar 11, 2026

Uh oh!

rdkcmf-jenkins commented Mar 11, 2026

Uh oh!

rdkcmf-jenkins commented Mar 12, 2026

Uh oh!

rdkcmf-jenkins commented Mar 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		#Journal conf overide
		sed -i -e 's/.ForwardToSyslog=./#ForwardToSyslog=no/g' ${D}${sysconfdir}/systemd/journald.conf

Conversation

maniselva006c commented Mar 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins commented Mar 11, 2026

Uh oh!

rdkcmf-jenkins commented Mar 11, 2026

Uh oh!

rdkcmf-jenkins commented Mar 12, 2026

Uh oh!

rdkcmf-jenkins commented Mar 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants