RDKEMW-6898: Add latest recipes for gssdp latest version.#402
RDKEMW-6898: Add latest recipes for gssdp latest version.#402
Conversation
Signed-off-by: balaji velmurugan <balaji_velmurugan@comcast.com>
…se-basename-instead-of-filen.patch
There was a problem hiding this comment.
Pull request overview
Adds newer GNOME UPnP stack recipes (GSSDP 1.6 + GUPnP 1.6 family) to the layer and pulls the new gssdp16 recipe into the OSS layer packagegroup, including a package revision entry for it.
Changes:
- Add
gssdp16topackagegroup-oss-layerRDEPENDS. - Introduce new BitBake recipes for
gssdp16,gupnp(1.6.x) and related components (gupnp-av,gupnp-dlna,gupnp-igd,gupnp-tools). - Add upstream/backport patches to improve reproducibility and compatibility (basename include templates; libxml deprecation fix).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| recipes-core/packagegroups/packagegroup-oss-layer.bb | Adds gssdp16 to the OSS layer packagegroup runtime deps. |
| recipes-connectivity/gupnp/gupnp/0001-gupnp-enums.c.template-use-basename-instead-of-filen.patch | Patch to avoid leaking build paths into generated sources. |
| recipes-connectivity/gupnp/gupnp-tools_0.12.1.bb | New recipe for GUPnP tools targeting the newer stack. |
| recipes-connectivity/gupnp/gupnp-igd_1.6.0.bb | New recipe for gupnp-igd for the newer stack. |
| recipes-connectivity/gupnp/gupnp-dlna_0.12.0.bb | New recipe for gupnp-dlna helpers. |
| recipes-connectivity/gupnp/gupnp-av/0001-all-Drop-xmlRecoverMemory.patch | Backport patch replacing deprecated libxml API usage. |
| recipes-connectivity/gupnp/gupnp-av_0.14.1.bb | New recipe for gupnp-av with the libxml deprecation patch. |
| recipes-connectivity/gupnp/gupnp_1.6.6.bb | New recipe for GUPnP 1.6.x using libsoup-3.0 and gssdp16. |
| recipes-connectivity/gupnp/gssdp16/0001-gssdp-enums.c.template-use-basename-instead-of-filen.patch | Patch to avoid build-path leakage in generated sources. |
| recipes-connectivity/gupnp/gssdp16_1.6.3.bb | New GSSDP 1.6 recipe variant (gssdp16). |
| conf/include/package_revisions_oss.inc | Adds PR/PACKAGE_ARCH entries for pn-gssdp16. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| inherit gnomebase pkgconfig vala gobject-introspection meson | ||
|
|
There was a problem hiding this comment.
inherit gnomebase ... meson is likely inheriting the default GNOME build class (typically autotools) because GNOMEBASEBUILDCLASS is not set before inherit gnomebase. For Meson-based GNOME projects, set GNOMEBASEBUILDCLASS = "meson" (before inheriting gnomebase) and drop the direct inherit meson here to avoid mixing build classes, which can break the build.
| inherit gnomebase pkgconfig vala gobject-introspection meson | |
| GNOMEBASEBUILDCLASS = "meson" | |
| inherit gnomebase pkgconfig vala gobject-introspection |
| gupnp-didl-lite-parser.c | 2 +- | ||
| gupnp-feature-list-parser.c | 2 +- | ||
| 2 files changed, 2 insertions(+), 2 deletions(-) | ||
|
|
||
| diff --git a/gupnp-didl-lite-parser.c b/gupnp-didl-lite-parser.c | ||
| index 3a5727f..840d718 100644 | ||
| --- a/libgupnp-av/gupnp-didl-lite-parser.c | ||
| +++ b/libgupnp-av/gupnp-didl-lite-parser.c |
There was a problem hiding this comment.
This patch’s headers are internally inconsistent: diff --git a/gupnp-didl-lite-parser.c ... / diff --git a/gupnp-feature-list-parser.c ... do not match the ---/+++ paths under libgupnp-av/. Align the diff --git paths (and the shortstat file list, if desired) with the actual paths to avoid patch tooling failing or creating confusing diagnostics.
|
|
||
| DEPENDS = "libxml2 glib-2.0" | ||
|
|
||
| SRC_URI = "http://download.gnome.org/sources/${BPN}/0.12/${BPN}-${PV}.tar.xz" |
There was a problem hiding this comment.
SRC_URI uses plain HTTP for the GNOME source tarball. Switch to HTTPS (or ${GNOME_MIRROR}) to avoid insecure transport and reduce exposure to MITM/availability issues during fetch.
| SRC_URI = "http://download.gnome.org/sources/${BPN}/0.12/${BPN}-${PV}.tar.xz" | |
| SRC_URI = "https://download.gnome.org/sources/${BPN}/0.12/${BPN}-${PV}.tar.xz" |
No description provided.