RDKTV-39704: [RDKE]Network manager crash during Standby State#407
Open
AravindanNC wants to merge 13 commits intodevelopfrom
Open
RDKTV-39704: [RDKE]Network manager crash during Standby State#407AravindanNC wants to merge 13 commits intodevelopfrom
AravindanNC wants to merge 13 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent a NetworkManager crash during standby/shutdown on RDKE by avoiding assertions in NMPolicy::dispose() and cleaning up internal state instead, delivered as a Yocto patch applied to NetworkManager 1.43.7.
Changes:
- Add a downstream patch to
src/core/nm-policy.cto clear the auto-activation list and unregister devices duringdispose(). - Update the Yocto
networkmanager_1.43.7.bbrecipe to apply the new patch.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| recipes-connectivity/networkmanager/networkmanager/NM_patch.patch | Adds nm-policy.c dispose-time cleanup to avoid shutdown assertions. |
| recipes-connectivity/networkmanager/networkmanager_1.43.7.bb | Applies the new patch via SRC_URI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Do not assert during shutdown, cleanup the interface instead.
Test Procedure: Build RDKE image
Signed-off-by: nc.aravindan@gmail.com