RDKBACCL-1524:Intermittently FW upgrade is not working#6
Closed
mahanteshchitt wants to merge 5 commits intodevelopfrom
Closed
RDKBACCL-1524:Intermittently FW upgrade is not working#6mahanteshchitt wants to merge 5 commits intodevelopfrom
mahanteshchitt wants to merge 5 commits intodevelopfrom
Conversation
Reason For Change: Intermittently Firmware upgrade is failing showing the error uncompression failed. Test Procedure : Firmware upgrade should work as expected. Risks: None. Signed-off-by: mahanteshchitt <mahantesh_chittapur@comcast.com>
manigandanj
reviewed
Mar 9, 2026
There was a problem hiding this comment.
Please replace all these system API call with run_command.
Contributor
Author
There was a problem hiding this comment.
okay, will address.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return -1; | ||
| } | ||
|
|
||
| ret = run_command(cmd, output, sizeof(output)); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in OS command Critical
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason For Change: Intermittently Firmware upgrade is failing showing the error uncompression failed.
Test Procedure : Firmware upgrade should work as expected.
Risks: None.