Rialto Server profiling by smudri85 · Pull Request #441 · rdkcentral/rialto

smudri85 · 2026-02-06T14:37:24Z

Summary: Add profiling to Rialto Server.
Type: Feature
Test Plan: UT/CT, Fullstack
Jira: RDKEMW-11764

github-actions · 2026-02-06T14:37:36Z

Pull request must be merged with a description containing the required fields,

Summary:
Type: Feature/Fix/Cleanup
Test Plan:
Jira:

If there is no jira releated to this change, please put 'Jira: NO-JIRA'.

Description can be changed by editing the top comment on your pull request and making a new commit.

github-actions · 2026-02-06T14:38:08Z

common/source/Profiler.cpp:98:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
if (record.stage == stage)
^
common/source/Profiler.cpp:111:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
if (record.stage == stage && record.info == info)
^
common/source/Profiler.cpp:184:0: style: Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
if (record.id == id)
^
nofile:0:0: information: Active checkers: 161/592 (use --checkers-report= to see details) [checkersReport]

rdkcmf-jenkins · 2026-02-06T14:41:11Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/rialto/441/rdkcentral/rialto
Commit: 282cf54

Report detail: gist'

Copilot

Pull request overview

This pull request adds profiling functionality to the Rialto Server to track performance metrics and pipeline events. The implementation includes a generic profiling interface in the common module and a GStreamer-specific profiler that integrates with the media player pipeline. The profiler records timestamped events at various stages of media playback and can be enabled via environment variable.

Changes:

Added core profiling infrastructure with IProfiler interface and Profiler implementation
Integrated GstProfiler into the media player pipeline to track key events
Added unit tests and mocks for the profiling functionality

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 25 comments.

Show a summary per file

File	Description
common/interface/IProfiler.h	Defines the profiler interface with methods for recording, finding, logging, and dumping profiling records
common/include/Profiler.h	Declares the concrete Profiler class implementation with internal Record structure
common/source/Profiler.cpp	Implements the profiler with thread-safe record storage, environment-based enabling, and file dumping
common/CMakeLists.txt	Adds Profiler.cpp to the build configuration
media/server/gstplayer/include/GstProfiler.h	Defines GStreamer-specific profiler wrapper for pipeline profiling
media/server/gstplayer/include/GenericPlayerContext.h	Adds GstProfiler instance to player context
media/server/gstplayer/source/GstProfiler.cpp	Implements GStreamer profiler with pad probe callbacks and element filtering
media/server/gstplayer/source/GstGenericPlayer.cpp	Integrates profiler into pipeline lifecycle (creation, termination, segment handling)
media/server/gstplayer/source/tasks/generic/HandleBusMessage.cpp	Records pipeline state changes
media/server/gstplayer/source/tasks/generic/FinishSetupSource.cpp	Records when all sources are attached
media/server/gstplayer/source/tasks/generic/AttachSource.cpp	Records AppSrc element creation
media/server/gstplayer/source/tasks/generic/DeepElementAdded.cpp	Schedules profiling for dynamically added GStreamer elements
media/server/gstplayer/CMakeLists.txt	Adds GstProfiler.cpp to build and includes common headers
tests/unittests/common/unittests/ProfilerTests.cpp	Unit tests for core profiler functionality
tests/unittests/common/unittests/CMakeLists.txt	Adds ProfilerTests.cpp to test build
tests/unittests/common/mocks/ProfilerMock.h	Mock implementation of IProfiler for testing
tests/unittests/common/mocks/ProfilerFactoryMock.h	Mock implementation of IProfilerFactory for testing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rdkcmf-jenkins · 2026-02-06T14:59:35Z

Coverity Issue - Uncaught exception

An exception of type "std::bad_optional_access" is thrown but the exception specification "/implicit/noexcept" doesn't allow it to be thrown. This will result in a call to terminate().

Medium Impact, CWE-248
UNCAUGHT_EXCEPT

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
media/server/gstplayer/source/GstGenericPlayer.cpp:210

mhughesacn · 2026-02-06T17:58:18Z

Hi @smudri85 : The blackduck issue is not a problem but all new code files should have proper headers please.

MartinH, RDK CMF Compliance Team

rdkcmf-jenkins · 2026-02-06T23:22:15Z

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

Upvote reason: ok
Commit: 282cf54
'

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 10 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-02-12T13:49:38Z

Coverage statistics of your commit:
WARNING: Lines coverage decreased from: 85.2% to 84.6%
WARNING: Functions coverage decreased from: 92.5% to 91.9%

rdkcmf-jenkins · 2026-04-03T19:45:00Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/rialto/441/rdkcentral/rialto
Commit: 024c46d

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 37 out of 37 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

smudri85 · 2026-04-23T10:10:52Z

+        gchar *rawName = m_gstWrapper->gstElementGetName(element);
+        elementInfo = deriveElementInfoFromName(rawName ? rawName : "<null>");
+        if (rawName)
+            m_glibWrapper->gFree(rawName);


This is false negative. From the method description at IGstWrapper.h:
... Caller should g_free the return value after usage ...

smudri85 · 2026-04-23T10:07:13Z

    }
+    if (appSrc)
+    {
+        auto recordId = m_context.gstProfiler->createRecord("Created AppSrc Element", std::move(profilerInfo));


github-actions · 2026-04-23T09:32:09Z

Coverage statistics of your commit:
WARNING: Lines coverage decreased from: 84.5% to 84.3%
Functions coverage stays unchanged and is: 92.6%

Summary: Add profiling to Rialto Server. Type: Feature Test Plan: UT/CT, Fullstack Jira: RDKEMW-11764

Summary: Add profiling to Rialto Server. Type: Feature Test Plan: UT/CT, Fullstack Jira: RDKEMW-117641

Summary: Add profiling to Rialto Server. Type: Feature Test Plan: UT/CT, Fullstack Jira: RDKEMW-11764

…ance as intended.

…ils.

github-actions · 2026-04-23T10:17:30Z

Coverage statistics of your commit:
WARNING: Lines coverage decreased from: 84.5% to 84.3%
Functions coverage stays unchanged and is: 92.6%

skywojciechowskim · 2026-04-24T08:19:27Z

+    if (!m_enabled || !m_profiler)
+        return;
+
+    (void)m_profiler->dumpToFile();


A warning if dumpToFile failed :)

skywojciechowskim · 2026-04-24T08:25:31Z

+    std::string info;
+};
+
+GstPadProbeReturn probeCb(GstPad *pad, GstPadProbeInfo *info, gpointer userData)


Well, that's better, but not exactly what I meant :)
That's what you should do if we want to have similar implementation everywhere and no new/delete:

Move ProbeCtx contents to GstDecryptor

Create GstPadProbeReturn GstDecryptor::handleProbeCb(GstPad *pad, GstPadProbeInfo *info) function and move the content of the function below there

Implementation of this function should be:
auto *self = static_cast<GstDecryptor *>(userData); return self->handleProbeCb(pad, info);

remove probe in GstDecryptor destructor

Probe registration will be:
m_gstWrapper->gstPadAddProbe(pad, GST_PAD_PROBE_TYPE_BUFFER, &probeCb, this, nullptr);
As you can see, no new/delete and destroy method is needed

skywojciechowskim · 2026-04-24T08:28:08Z


    for key in suites:
        executeCmd = []
+        cmdEnv = os.environ.copy()


So why those 2 lines are needed?

Copilot AI review requested due to automatic review settings February 6, 2026 14:37

Copilot started reviewing on behalf of smudri85 February 6, 2026 14:37 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

rdkcmf-jenkins reviewed Feb 6, 2026

View reviewed changes

Comment thread media/server/gstplayer/source/GstProfiler.cpp Outdated

Comment thread media/server/gstplayer/source/GstProfiler.cpp Outdated

Comment thread media/server/gstplayer/source/GstProfiler.cpp Outdated

Comment thread media/server/gstplayer/source/GstProfiler.cpp Outdated

Copilot AI review requested due to automatic review settings February 11, 2026 12:19

smudri85 force-pushed the feature/RDKEMW-11764 branch from 95cc046 to 43eb771 Compare February 11, 2026 12:19

Copilot started reviewing on behalf of smudri85 February 11, 2026 12:20 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

smudri85 force-pushed the feature/RDKEMW-11764 branch from 43eb771 to e476ba7 Compare February 11, 2026 13:45

Copilot AI review requested due to automatic review settings February 11, 2026 14:06

smudri85 force-pushed the feature/RDKEMW-11764 branch from e476ba7 to 5862d6c Compare February 11, 2026 14:06

Copilot started reviewing on behalf of smudri85 February 11, 2026 14:06 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

smudri85 force-pushed the feature/RDKEMW-11764 branch 2 times, most recently from 3934f05 to 761b259 Compare February 12, 2026 09:18

Copilot AI review requested due to automatic review settings February 12, 2026 09:18

Copilot started reviewing on behalf of smudri85 February 12, 2026 09:18 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

smudri85 force-pushed the feature/RDKEMW-11764 branch from 761b259 to 3d607f2 Compare February 12, 2026 13:28

Copilot AI review requested due to automatic review settings April 3, 2026 19:42

smudri85 force-pushed the feature/RDKEMW-11764 branch from 3d607f2 to 024c46d Compare April 3, 2026 19:42

Copilot started reviewing on behalf of smudri85 April 3, 2026 19:42 View session

Copilot AI review requested due to automatic review settings April 22, 2026 14:08

smudri85 force-pushed the feature/RDKEMW-11764 branch from 7f24ab6 to 289c905 Compare April 22, 2026 14:08

Copilot started reviewing on behalf of smudri85 April 22, 2026 14:08 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

smudri85 force-pushed the feature/RDKEMW-11764 branch from 289c905 to 44b708d Compare April 23, 2026 09:21

Sasa Mudri added 21 commits April 23, 2026 12:05

Added Profiler and GstProfiler classes.

d95b318

Summary: Add profiling to Rialto Server. Type: Feature Test Plan: UT/CT, Fullstack Jira: RDKEMW-11764

Updated Profiler and GstProfiler classes.

32fd517

Summary: Add profiling to Rialto Server. Type: Feature Test Plan: UT/CT, Fullstack Jira: RDKEMW-117641

Added IProfiler interface, dump() method and additional changes.

fd82792

Summary: Add profiling to Rialto Server. Type: Feature Test Plan: UT/CT, Fullstack Jira: RDKEMW-11764

Added Profiler configuration (enable/disable) via environment variable.

840674b

Summary: Add profiling to Rialto Server. Type: Feature Test Plan: UT/CT, Fullstack Jira: RDKEMW-11764

Added descriptions for IProfiler and some small fixes.

89171a0

Summary: Add profiling to Rialto Server. Type: Feature Test Plan: UT/CT, Fullstack Jira: RDKEMW-11764

Added mocks and unit tests for IProfiler.

43e72a3

Summary: Add profiling to Rialto Server. Type: Feature Test Plan: UT/CT, Fullstack Jira: RDKEMW-11764

Tiny change for deep element record stage name.

0d323ea

Summary: Add profiling to Rialto Server. Type: Feature Test Plan: UT/CT, Fullstack Jira: RDKEMW-11764

Added 'github actions' compliance changes.

2349c34

Summary: Add profiling to Rialto Server. Type: Feature Test Plan: UT/CT, Fullstack Jira: RDKEMW-11764

Handle rialto decryptor element in GstProfiler.

edaa85d

Changing to using system clock for profiler timestamp values.

b47340b

Create tune data and log in one line.

6f67b0a

Added UTs for GstProfiler and modified existing ones for Profiler.

d05c074

Resolve issues reported by Copilot.

3880444

Added changes to GstProfiler and GstGenericPlayer to use factory inst…

3d8e381

…ance as intended.

Removed unused find() methods from Profiler and updated UTs.

0930ccc

Removed processElementName() and used existing isVideo and isAudio ut…

1a91bad

…ils.

Updated dump() method and added global env var for dump file config.

2ab57f1

Add element clasification (video/audio) by name.

9734199

Resolve CI errors.

72aa00f

Resolve GitHub Copilot comments.

9a29cf9

Resolve review comments.

71ea315

smudri85 force-pushed the feature/RDKEMW-11764 branch from 44b708d to 71ea315 Compare April 23, 2026 10:06

skywojciechowskim requested changes Apr 24, 2026

View reviewed changes

Conversation

smudri85 commented Feb 6, 2026

Uh oh!

github-actions Bot commented Feb 6, 2026

Uh oh!

github-actions Bot commented Feb 6, 2026

Uh oh!

rdkcmf-jenkins commented Feb 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rdkcmf-jenkins commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverity Issue - Uncaught exception

Issue location

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mhughesacn commented Feb 6, 2026

Uh oh!

rdkcmf-jenkins commented Feb 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Feb 12, 2026

Uh oh!

rdkcmf-jenkins commented Apr 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

rdkcmf-jenkins commented Feb 6, 2026 •

edited

Loading