RDKEMW-15487 [Rialto][CPU] High CPU Usage of Rialto Server - Checkpoint4#465
RDKEMW-15487 [Rialto][CPU] High CPU Usage of Rialto Server - Checkpoint4#465rekhap2kandhavelan wants to merge 2 commits intomasterfrom
Conversation
|
Pull request must be merged with a description containing the required fields, Summary: If there is no jira releated to this change, please put 'Jira: NO-JIRA'. Description can be changed by editing the top comment on your pull request and making a new commit. |
There was a problem hiding this comment.
Pull request overview
This PR adds additional logging around the playback-info notification path to help diagnose high CPU usage in the Rialto server.
Changes:
- Add a debug log when entering
GST_STATE_PAUSEDbefore starting the notify-playback-info timer. - Add timing + cycle counting logs inside
GstGenericPlayer::notifyPlaybackInfo(). - Add debug logs when starting (or skipping start of) the NotifyPlaybackInfo timer.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
media/server/gstplayer/source/tasks/generic/HandleBusMessage.cpp |
Adds a debug log when PAUSED triggers starting the playback-info timer. |
media/server/gstplayer/source/GstGenericPlayer.cpp |
Adds instrumentation (timing/counter) to notifyPlaybackInfo() and logs timer start/duplicate-start. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if ((currentCount % 1) == 0) | ||
| { | ||
| RIALTO_SERVER_LOG_INFO("notifyPlaybackInfo cycle %d took %lld us", currentCount, | ||
| static_cast<long long>(elapsed.count())); | ||
| } |
| static std::atomic<int> notifyCount{0}; | ||
| const int currentCount = ++notifyCount; | ||
| const auto start = std::chrono::steady_clock::now(); |
|
Coverage statistics of your commit: |
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Added debugs