Update GstDecryptor.cpp#468
Conversation
|
Pull request must be merged with a description containing the required fields, Summary: If there is no jira releated to this change, please put 'Jira: NO-JIRA'. Description can be changed by editing the top comment on your pull request and making a new commit. |
There was a problem hiding this comment.
Pull request overview
This PR adds a runtime debug print in the GStreamer decryptor path to surface when decrypt() is called and with which parameters.
Changes:
- Added a
printfstatement inGstRialtoDecryptorPrivate::decrypt()to logkeySessionId,buffer, andcapspointers before callingm_decryptionService->decrypt().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| else | ||
| { | ||
| printf("VRN decrypt called with keySessionId=%s, buffer=%p, caps=%p\n", protectionData->keySessionId.c_str(), buffer, caps); |
There was a problem hiding this comment.
The added printf logs on every decrypt call (hot path, per-buffer) directly to stdout, which can significantly impact performance and operational logging (unstructured output, hard to filter/route) and may leak DRM/session identifiers (keySessionId). Please remove this, or switch to the existing logging system (e.g., GST_TRACE_OBJECT/GST_DEBUG_OBJECT or RIALTO_SERVER_LOG_DEBUG) and ensure any session identifiers are either omitted, redacted, or only logged under an explicit debug flag.
| printf("VRN decrypt called with keySessionId=%s, buffer=%p, caps=%p\n", protectionData->keySessionId.c_str(), buffer, caps); | |
| GST_TRACE_OBJECT(self, "VRN decrypt called (buffer=%p, caps=%p)", buffer, caps); |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Coverage statistics of your commit: |
No description provided.