Telemetry markers for Server Manager#474
Telemetry markers for Server Manager#474Koky2701 wants to merge 2 commits intofeature/RDKEMW-16516from
Conversation
Koky2701
commented
Apr 9, 2026
Koky2701
commented
Summary: Integrating telemetry T2 markers into Rialto Type: Fix Test Plan: UT/CT, Fullstack Jira: RDKEMW-16516
There was a problem hiding this comment.
Pull request overview
Integrates Telemetry (T2) string events into Rialto Server Manager to emit markers on key error/recovery paths, complementing existing log messages.
Changes:
- Emit a telemetry event when the IPC client disconnects unexpectedly and recovery is triggered.
- Emit telemetry events for session server connection/configuration/state-change failure paths.
- Emit a telemetry event when healthcheck ping failures hit the recovery threshold.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
serverManager/ipc/source/Client.cpp |
Adds telemetry marker on unexpected disconnect before restarting the server. |
serverManager/common/source/SessionServerAppManager.cpp |
Adds telemetry markers for connect/configure/state-change failure cases. |
serverManager/common/source/HealthcheckService.cpp |
Adds telemetry marker when failed pings trigger recovery. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| char telemetryBuff[128] = {0}; | ||
| snprintf(telemetryBuff, sizeof(telemetryBuff), | ||
| "Connection to serverId: %d broken, server probably crashed. Starting recovery", | ||
| m_serverId); | ||
| TELEMETRY_EVENT_STRING("Rialto Server Manager - Client", telemetryBuff); |
There was a problem hiding this comment.
snprintf is used here but this translation unit doesn’t include <cstdio>/<stdio.h>, and RialtoServerManagerLogging.h also doesn’t include it (unlike media/client/common/include/RialtoClientLogging.h). This can cause build failures depending on toolchain/headers. Add the appropriate header include (either in this .cpp or in the shared server-manager logging header).
| char telemetryBuff[128] = {0}; | ||
| snprintf(telemetryBuff, sizeof(telemetryBuff), | ||
| "Unable to connect Session Server - pointer is null!"); | ||
| TELEMETRY_EVENT_STRING("Rialto Server Manager - SessionServerAppManager", telemetryBuff); |
There was a problem hiding this comment.
snprintf is used in this file but there’s no <cstdio>/<stdio.h> include pulled in by the current includes (and serverManager/common/include/RialtoServerManagerLogging.h doesn’t include it). Please add the proper header include (once, near the top of the file, or via a shared header) so these telemetry snprintf calls compile reliably.
| char telemetryBuff[128] = {0}; | ||
| snprintf(telemetryBuff, sizeof(telemetryBuff), | ||
| "Max num of failed pings reached for server with id: %d. Starting recovery action", serverId); | ||
| TELEMETRY_EVENT_STRING("Rialto Server Manager - HealthcheckService", telemetryBuff); |
There was a problem hiding this comment.
snprintf is introduced here but this file doesn’t include <cstdio>/<stdio.h>, and the current includes don’t appear to provide it. Please add the correct header include so this compiles consistently across toolchains.
|
@Koky2701 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
2 similar comments
|
@Koky2701 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@Koky2701 Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
Koky2701
force-pushed
the
feature/RDKEMW-16516
branch
3 times, most recently
from
507f494 to
9bbf1a5
Compare
Summary: Integrating telemetry T2 markers into Rialto Server Manager
Type: Fix
Test Plan: UT/CT, Fullstack
Jira: RDKEMW-16519
Koky2701
force-pushed
the
feature/RDKEMW-16519
branch
from
d966ba4 to
de1dd07
Compare
Koky2701
force-pushed
the
feature/RDKEMW-16516
branch
2 times, most recently
from
a7ba470 to
b187cc1
Compare
Koky2701
force-pushed
the
feature/RDKEMW-16516
branch
from
b187cc1 to
836cc25
Compare
