[VIPA][Rialto]gstDecode regression in RDKE Sprint NG builds by rekhap2kandhavelan · Pull Request #475 · rdkcentral/rialto

rekhap2kandhavelan · 2026-04-13T11:02:42Z

[VIPA][Rialto]gstDecode regression in RDKE Sprint NG builds

Summary: retain preroll frames count to resolve vipa tune time issue
Type: Fix
Test Plan: UT/CT, Fullstack
Jira: RDKEMW-13498

facing yoututbe test fail for frame dropped so increasing the preroll frames

github-actions · 2026-04-13T11:04:29Z

Pull request must be merged with a description containing the required fields,

Summary:
Type: Feature/Fix/Cleanup
Test Plan:
Jira:

If there is no jira releated to this change, please put 'Jira: NO-JIRA'.

Description can be changed by editing the top comment on your pull request and making a new commit.

Copilot

Pull request overview

Adjusts server-side NeedMediaData behavior to request fewer frames while the pipeline is not yet playing (preroll/non-playing), aiming to address a gstDecode regression in RDKE Sprint NG builds by retaining an intended preroll frame request count.

Changes:

Dynamically sets NeedMediaData’s requested frame count to a smaller value when playback state is not PLAYING.
Introduces a new shared constant kPrerollNumFrames to represent the preroll frame request count.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
`media/server/main/source/NeedMediaData.cpp`	Chooses between max frames vs preroll frames based on current playback state.
`media/server/main/include/ShmUtils.h`	Adds `kPrerollNumFrames` constant alongside existing SHM sizing constants.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

svc-rdkeportal01 · 2026-04-17T10:42:59Z

CCI-Build-Verified -1
sha: ac271e6

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-04-20T10:46:03Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.4%
Functions coverage stays unchanged and is: 92.5%

github-actions · 2026-04-20T10:49:00Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.6%

rekhap2kandhavelan · 2026-04-22T08:36:52Z

I have read the CLA Document and I hereby sign the CLA

github-actions · 2026-04-22T09:23:34Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.6%

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-22T11:08:48Z

 constexpr std::uint32_t kMetadataOffset{1024};
 constexpr int kRequestId{0};
+constexpr int kPrerollingNumFrames{10};
 constexpr int kMaxFrames{24};
 constexpr int kMaxMetadataBytes{2500};


The new test hard-codes the preroll frame count (kPrerollingNumFrames{10}) even though production now defines kPrerollNumFrames in ShmUtils.h. To avoid tests drifting from production behavior, consider reusing the production constant (or including it via a shared header) rather than duplicating the value here.

Copilot · 2026-04-22T11:08:49Z

+TEST_F(NeedMediaDataTests, shouldSendMessageInPrerollingState)
+{
+    initialize(firebolt::rialto::PlaybackState::PAUSED);
+    needMediaDataWillBeSentBelowPlayingState();
+}


This test is named "shouldSendMessageInPrerollingState" but it initializes the SUT with PlaybackState::PAUSED. Since PAUSED is a distinct state (and not described as prerolling in the PlaybackState docs), the name is misleading—either use a state that actually represents preroll behavior in this codebase or rename the test to match the state being exercised (e.g. paused/below-playing).

github-actions · 2026-04-22T11:14:10Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.6%

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rekhap2kandhavelan added 3 commits April 8, 2026 15:30

Update ShmUtils.h

8a32833

Update NeedMediaData.cpp

76065d4

Update ShmUtils.h

ac271e6

facing yoututbe test fail for frame dropped so increasing the preroll frames

Copilot AI review requested due to automatic review settings April 13, 2026 11:02

This comment was marked as resolved.

Sign in to view

Copilot started reviewing on behalf of rekhap2kandhavelan April 13, 2026 11:03 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Comment thread media/server/main/source/NeedMediaData.cpp Outdated

Comment thread media/server/main/source/NeedMediaData.cpp

Comment thread media/server/main/include/ShmUtils.h

rekhap2kandhavelan added 2 commits April 19, 2026 19:11

Merge branch 'master' into feature/RDKEMW-13498

c0ce2ca

Update NeedMediaData.cpp

2be5691

Copilot AI review requested due to automatic review settings April 19, 2026 13:42

Copilot started reviewing on behalf of rekhap2kandhavelan April 19, 2026 13:42 View session

Copilot AI reviewed Apr 19, 2026

View reviewed changes

rekhap2kandhavelan and others added 2 commits April 20, 2026 13:45

Merge branch 'master' into feature/RDKEMW-13498

6fa77de

resolve unittest failure

35bd9a6

Copilot AI review requested due to automatic review settings April 20, 2026 10:36

Copilot started reviewing on behalf of rekhap2kandhavelan April 20, 2026 10:36 View session

Merge branch 'master' into feature/RDKEMW-13498

725c58b

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread tests/unittests/media/server/main/needMediaData/NeedMediaDataTestsFixture.h Outdated

Comment thread tests/unittests/media/server/main/mediaPipeline/CallbackTest.cpp

Comment thread tests/unittests/media/server/main/needMediaData/NeedMediaDataTestsFixture.h Outdated

Update googletest.cmake

ab6d09d

rekhap2kandhavelan changed the title ~~RDKEMW-13498 : [VIPA][Rialto]gstDecode regression in RDKE Sprint NG builds~~ [VIPA][Rialto]gstDecode regression in RDKE Sprint NG builds Apr 22, 2026

Update MediaPipelineTest.cpp

c8aa98e

Copilot AI review requested due to automatic review settings April 22, 2026 09:44

Copilot started reviewing on behalf of rekhap2kandhavelan April 22, 2026 09:44 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

rekhap2kandhavelan and others added 2 commits April 22, 2026 15:54

Update EncryptedPlaybackTest.cpp

e784710

resolved unit test result

e032d26

Copilot AI review requested due to automatic review settings April 22, 2026 11:03

Copilot started reviewing on behalf of rekhap2kandhavelan April 22, 2026 11:04 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

rkandh015 and others added 2 commits April 22, 2026 16:52

Apply clang-format auto-formatting

3731841

Update cmake/googletest.cmake

e6cf6b9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 22, 2026 11:35

Copilot started reviewing on behalf of rekhap2kandhavelan April 22, 2026 11:36 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

Conversation

rekhap2kandhavelan commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

github-actions Bot commented Apr 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

svc-rdkeportal01 commented Apr 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

rekhap2kandhavelan commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rekhap2kandhavelan commented Apr 13, 2026 •

edited

Loading