Refactor TextTrackPluginWrapper to include module definition and headers in source file#482
Open
bramoosterhuis wants to merge 1 commit intordkcentral:masterfrom
Conversation
…ers in source file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix undefined reference to
TextTrackClosedCaptionsStyleClientTextTrackPluginWrapper.hdefinedMODULE_NAMEasTextTrackClosedCaptionsStyleClientandincluded
<com/com.h>and<core/core.h>. This causedCallsignTLS<&TextTrackClosedCaptionsStyleClient>to be instantiated in every translation unit that included the header. However
TextTrackClosedCaptionsStyleClientwas never defined anywhere, resulting in an undefined reference at link time for any library linking
against
libRialtoWrappers.Changes
MODULE_NAMEdefinition and Thunder includes fromTextTrackPluginWrapper.hTextTrackPluginWrapper.cppas the owning translation unitMODULE_NAME_ARCHIVE_DECLARATIONto properly defineTextTrackClosedCaptionsStyleClientWhy
MODULE_NAME_ARCHIVE_DECLARATIONlibRialtoWrappersis a static library — the archive variant is correct here as it omits theshared library metadata registration that
MODULE_NAME_DECLARATIONadds.Impact
Downstream packages linking against
libRialtoWrapperswere failing withundefined reference to 'TextTrackClosedCaptionsStyleClient'at link time.This fix resolves that.