Conversation
|
Pull request must be merged with a description containing the required fields, Summary: If there is no jira releated to this change, please put 'Jira: NO-JIRA'. Description can be changed by editing the top comment on your pull request and making a new commit. |
There was a problem hiding this comment.
Pull request overview
Integrates rdk_perf instrumentation into the Rialto server startup path, and attempts to add the required perf libraries to the build so the server can be linked with the new dependency.
Changes:
- Add
rdk_perf.hinclude and instantiate anRDKPerfRAII object inRialtoServer’smain(). - Add
rdkperf/perftoollink dependencies to theRialtoCommonCMake target.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| media/server/service/source/main.cpp | Adds RDKPerf startup instrumentation in main(). |
| common/CMakeLists.txt | Adds perf libraries to RialtoCommon link interface. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const char kSrcRev[] = SRCREV; | ||
| const char kTags[] = TAGS; | ||
|
|
||
| RDKPerf perf(__FUNCTION__); |
There was a problem hiding this comment.
RDKPerf perf(__FUNCTION__); is never referenced. With repo-wide -Wall -Werror enabled, this is likely to fail the build due to -Wunused-variable. If the object is meant to exist only for RAII timing, mark it [[maybe_unused]] (or otherwise explicitly suppress the unused-variable warning) so the build remains warning-free.
| RDKPerf perf(__FUNCTION__); | |
| [[maybe_unused]] RDKPerf perf(__FUNCTION__); |
| PUBLIC | ||
| rdkperf perftool |
There was a problem hiding this comment.
Linking rdkperf/perftool as PUBLIC dependencies of RialtoCommon makes every consumer (client, serverManager, tests, etc.) transitively require these external libraries, even though the new usage is only in the server's main.cpp. This can break builds/environments that don't ship these libs and also increases coupling; instead, link these dependencies only in the specific target(s) that use them (e.g., the server executable or a dedicated perf target), and add proper find_package/find_library/imported-target discovery so CMake fails early with a clear error when the dependency isn't available.
| PUBLIC | |
| rdkperf perftool |
Integrating rdk_perf