Skip to content

Feature/rdkemw 17139#488

Open
balasaraswathy-n wants to merge 5 commits intomasterfrom
feature/rdkemw-17139
Open

Feature/rdkemw 17139#488
balasaraswathy-n wants to merge 5 commits intomasterfrom
feature/rdkemw-17139

Conversation

@balasaraswathy-n
Copy link
Copy Markdown

Integrating rdk_perf

Copilot AI review requested due to automatic review settings April 24, 2026 13:54
@github-actions
Copy link
Copy Markdown

Pull request must be merged with a description containing the required fields,

Summary:
Type: Feature/Fix/Cleanup
Test Plan:
Jira:

If there is no jira releated to this change, please put 'Jira: NO-JIRA'.

Description can be changed by editing the top comment on your pull request and making a new commit.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Integrates rdk_perf instrumentation into the Rialto server startup path, and attempts to add the required perf libraries to the build so the server can be linked with the new dependency.

Changes:

  • Add rdk_perf.h include and instantiate an RDKPerf RAII object in RialtoServer’s main().
  • Add rdkperf/perftool link dependencies to the RialtoCommon CMake target.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
media/server/service/source/main.cpp Adds RDKPerf startup instrumentation in main().
common/CMakeLists.txt Adds perf libraries to RialtoCommon link interface.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

const char kSrcRev[] = SRCREV;
const char kTags[] = TAGS;

RDKPerf perf(__FUNCTION__);
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RDKPerf perf(__FUNCTION__); is never referenced. With repo-wide -Wall -Werror enabled, this is likely to fail the build due to -Wunused-variable. If the object is meant to exist only for RAII timing, mark it [[maybe_unused]] (or otherwise explicitly suppress the unused-variable warning) so the build remains warning-free.

Suggested change
RDKPerf perf(__FUNCTION__);
[[maybe_unused]] RDKPerf perf(__FUNCTION__);

Copilot uses AI. Check for mistakes.
Comment thread common/CMakeLists.txt Outdated
Comment on lines +56 to +57
PUBLIC
rdkperf perftool
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking rdkperf/perftool as PUBLIC dependencies of RialtoCommon makes every consumer (client, serverManager, tests, etc.) transitively require these external libraries, even though the new usage is only in the server's main.cpp. This can break builds/environments that don't ship these libs and also increases coupling; instead, link these dependencies only in the specific target(s) that use them (e.g., the server executable or a dedicated perf target), and add proper find_package/find_library/imported-target discovery so CMake fails early with a clear error when the dependency isn't available.

Suggested change
PUBLIC
rdkperf perftool

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants