Skip to content

LTE-2882: Parodus process was not up#21

Open
guruchandru wants to merge 4 commits intodevelopfrom
feature/LTE-2882
Open

LTE-2882: Parodus process was not up#21
guruchandru wants to merge 4 commits intodevelopfrom
feature/LTE-2882

Conversation

@guruchandru
Copy link
Copy Markdown

LTE-2882: Parodus process was not running in XLE

Reason for change: To avoid parodus not up when nvram is corrupted.
Test Procedure: Remove the following files and restart parodus it should run
1. /nvram/bootstrap.json
2. /opt/secure/bootstrap.json
3. /nvram/partners_defaults.json

Risks: Low
Priority: P1

@guruchandru guruchandru requested review from a team as code owners March 16, 2026 20:56
Copilot AI review requested due to automatic review settings March 16, 2026 20:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses cases where Parodus fails to start when NVRAM-derived configuration is missing/corrupted by adding a partner-default JSON fallback for critical WebPA URLs.

Changes:

  • Add partner-JSON lookup helpers to fetch partner-specific WebPA/TOKEN/DNS URL parameters.
  • Invoke the partner-JSON fallback during startup when a PartnerID is available and URL values are empty.
  • Broaden the “default webpaUrl” assignment to also trigger when webpaUrl is an empty string.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread source/parodusStart/start_parodus.c
Comment thread source/parodusStart/start_parodus.c Outdated
Comment thread source/parodusStart/start_parodus.c
Comment thread source/parodusStart/start_parodus.c
Comment thread source/parodusStart/start_parodus.c
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 31, 2026 17:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to prevent parodus startup failures when NVRAM-backed configuration is corrupted by adding a fallback to partner defaults JSON for critical WebPA URLs.

Changes:

  • Add partner-defaults JSON lookup for WebPA “crucial URLs” (server/token/DNS TXT) when unset.
  • Update startup logic to treat empty webpaUrl as unset and populate it from WEBPA_SERVER_URL.
  • Introduce helper functions and TR-181 parameter name constants for partner-specific URL retrieval.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/parodusStart/start_parodus.c
Comment thread source/parodusStart/start_parodus.c Outdated
Comment thread source/parodusStart/start_parodus.c
Comment thread source/parodusStart/start_parodus.c
Comment thread source/parodusStart/start_parodus.c
Copilot AI review requested due to automatic review settings March 31, 2026 18:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/parodusStart/start_parodus.c
Comment thread source/parodusStart/start_parodus.c
Comment thread source/parodusStart/start_parodus.c
Comment thread source/test/start_parodus_test.cpp
Comment thread source/parodusStart/start_parodus.c
Copilot AI review requested due to automatic review settings March 31, 2026 20:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/test/start_parodus_test.cpp
Comment thread source/parodusStart/start_parodus.c
Comment thread source/parodusStart/start_parodus.c
Comment thread source/parodusStart/start_parodus.c
Copilot AI review requested due to automatic review settings March 31, 2026 21:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/test/start_parodus_test.cpp
Copilot AI review requested due to automatic review settings March 31, 2026 22:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/parodusStart/start_parodus.c
Copilot AI review requested due to automatic review settings April 1, 2026 17:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/parodusStart/start_parodus.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants