Issue 131: Update CMakeLists.txt to fix deprecation warnings#132
Open
jcarrete5 wants to merge 7 commits intordkcentral:mainfrom
Open
Issue 131: Update CMakeLists.txt to fix deprecation warnings#132jcarrete5 wants to merge 7 commits intordkcentral:mainfrom
jcarrete5 wants to merge 7 commits intordkcentral:mainfrom
Conversation
jcarrete5
force-pushed
the
fix-deprecation-warnings
branch
from
1ae3706 to
afb2dd5
Compare
The CTest module, in addition to providing a bunch of extra targets related to testing, also includes functionality for Coverage and MemCheck. Better to leave this as-is despite it being kinda hacky.
jcarrete5
force-pushed
the
fix-deprecation-warnings
branch
from
afb2dd5 to
0b31078
Compare
mhabrat
approved these changes
Sep 23, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the reference implementation’s CMake configuration to eliminate deprecation warnings from modern CMake/FetchContent usage and from the bundled GoogleTest project during test builds.
Changes:
- Replace deprecated
FetchContent_Populate+ manualadd_subdirectorywithFetchContent_MakeAvailable. - Bump GoogleTest from
v1.13.0tov1.15.2to address upstream CMake deprecation warnings. - Clean up the
BUILD_TESTSconditional to useif(BUILD_TESTS).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #131
The newer version of googletest fixes the CMake deprecation warnings when building with more modern versions of CMake without breaking our tests and
FetchContent_MakeAvailableis preferable toFetchContent_Populate.