RDKEMW-13235:Renaming StorageManager to AppStorageManager

[Sonajeya31]

Reason for Change: To avoid confusion in calling storagemanager related to appmanagers
Test Procedure: Build and verify

[Copilot]

Pull request overview

Updates the WPEFramework systemd service units to reflect a StorageManager plugin rename and to add initialiser units for additional WPEFramework plugins.

Changes:

• Renames the activated plugin in wpeframework-appstoragemanager.service from org.rdk.StorageManager to org.rdk.AppStorageManager.
• Adds multiple new oneshot systemd units to activate additional WPEFramework plugins after WPEFramework startup.
• Removes the /opt/appgatewayenabled gating condition from AppGateway-related units.

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
systemd/system/wpeframework-xvpclient.service	New unit to activate XvpClient plugin.
systemd/system/wpeframework-wifimetrics.service	New unit to activate WifiMetrics plugin.
systemd/system/wpeframework-watermark.service	New unit to activate Watermark plugin (mount-related).
systemd/system/wpeframework-texttrack.service	New unit to activate TextTrack plugin (includes ExecStartPre).
systemd/system/wpeframework-secmanager.service	New unit to activate SecManager plugin.
systemd/system/wpeframework-privacy.service	New unit to activate Privacy plugin.
systemd/system/wpeframework-ottservices.service	New unit to activate OttServices plugin with badger conditions.
systemd/system/wpeframework-mediasettings.service	New unit to activate MediaSettings plugin.
systemd/system/wpeframework-lostandfound.service	New unit to activate LostAndFound plugin (+ Install/WantedBy).
systemd/system/wpeframework-linchpinclient.service	New unit to activate LinchPinClient plugin.
systemd/system/wpeframework-launchdelegate.service	New unit to activate LaunchDelegate plugin.
systemd/system/wpeframework-ipcontrol.service	New unit to activate IPControl plugin (+ iptables hooks).
systemd/system/wpeframework-fbprivacy.service	New unit to activate FbPrivacy plugin.
systemd/system/wpeframework-fbmetrics.service	New unit to activate FbMetrics plugin.
systemd/system/wpeframework-fbentos.service	New unit to activate FbEntos plugin.
systemd/system/wpeframework-fbdiscovery.service	New unit to activate FbDiscovery plugin.
systemd/system/wpeframework-fbaslinchpin.service	New unit to activate FbAsLinchPin plugin.
systemd/system/wpeframework-fbadvertising.service	New unit to activate FbAdvertising plugin.
systemd/system/wpeframework-deviceprovisioning.service	New unit to activate DeviceProvisioning plugin.
systemd/system/wpeframework-contentprotection.service	New unit to activate ContentProtection plugin.
systemd/system/wpeframework-badger.service	New unit to activate Badger plugin with badger conditions.
systemd/system/wpeframework-authservice.service	New unit to activate AuthService plugin.
systemd/system/wpeframework-appstoragemanager.service	Switches activated plugin to AppStorageManager.
systemd/system/wpeframework-appnotifications.service	Removes /opt/appgatewayenabled condition gate.
systemd/system/wpeframework-appgatewaycommon.service	Removes /opt/appgatewayenabled condition gate.
systemd/system/wpeframework-appgateway.service	Removes /opt/appgatewayenabled condition gate.

Comments suppressed due to low confidence (1)

systemd/system/wpeframework-appstoragemanager.service:11

• wpeframework-appstoragemanager.service now activates org.rdk.AppStorageManager, but the unit Description still says "StorageManager". Update the Description (and any other human-facing references in this unit) to match the renamed plugin to avoid ongoing confusion.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 29 out of 29 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

systemd/system/wpeframework-appstoragemanager.service:11

• This unit now activates org.rdk.AppStorageManager, but the unit metadata still describes it as StorageManager (see Description= earlier in this file). Update the description (and any other labels) to AppStorageManager to match the renamed plugin and reduce operational confusion when troubleshooting via systemctl status/logs.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The PR renames StorageManager -> AppStorageManager, but the codebase still has at least one unit depending on the old (now non-existent) wpeframework-storagemanager.service (systemd/system/wpeframework-runtimemanager.service). This will cause systemd dependency failures when starting RuntimeManager. Update remaining dependencies to wpeframework-appstoragemanager.service (or reintroduce the old unit as an alias) so all plugins consistently depend on the renamed service.

[Copilot]

The PR renames StorageManager -> AppStorageManager, but the codebase still has at least one unit depending on the old (now non-existent) wpeframework-storagemanager.service (systemd/system/wpeframework-runtimemanager.service). This will cause systemd dependency failures when starting RuntimeManager. Update remaining dependencies to wpeframework-appstoragemanager.service (or reintroduce the old unit as an alias) so all plugins consistently depend on the renamed service.

[Copilot]

After= includes wpeframework-persistentstore.service but Requires= does not. If PersistentStore is required for TextTrack to function, it should be in Requires= as well; if it’s only an ordering preference, consider removing it from After=. The current mix can lead to TextTrack starting without PersistentStore being pulled in.