RDKEMW-7075: COM-RPC support to SystemService plugin#208
Open
RDKEMW-7075: COM-RPC support to SystemService plugin#208
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts systemd unit dependencies for WPEFramework plugin activation to support updated startup ordering around the SystemService plugin (as part of adding COM-RPC support).
Changes:
- Removed
wpeframework-system.servicefromwpeframework-telemetry.servicedependencies to avoid coupling/ordering on System initialisation. - Updated
wpeframework-system.serviceto require and order-after additional WPEFramework plugin initialiser units (including telemetry, deviceinfo, firmwareupdate, migration).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
systemd/system/wpeframework-telemetry.service |
Drops dependency on wpeframework-system.service, leaving ordering based on PowerManager/UserSettings. |
systemd/system/wpeframework-system.service |
Expands Requires=/After= to include additional plugin initialisers (deviceinfo/firmwareupdate/telemetry/migration). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: COM-RPC support to SystemServices plugin
Test Procedure: Ensure all the services loaded
Risks: Low
Priority: P1
version: Patch
Signed-off-by:Dineshkumar P [dinesh_kumar2@comcast.com]