Skip to content

RDK-60581: Systemd Service Dependency Clean-up#215

Open
gururaajar wants to merge 5 commits intodevelopfrom
topic/RDK-60581
Open

RDK-60581: Systemd Service Dependency Clean-up#215
gururaajar wants to merge 5 commits intodevelopfrom
topic/RDK-60581

Conversation

@gururaajar
Copy link
Copy Markdown
Contributor

Reason for Change: Removed unneeded dependency
Test Procedure: Check whether the plugin starts in sqeuence and there is no regression
Priority: P1
Risks: Medium

Reason for Change: Removed unneeded dependency
Test Procedure: Check whether the plugin starts in sqeuence and there is no regression
Priority: P1
Risks: Medium
Signed-off-by: Gururaaja ESR<Gururaja_ErodeSriranganRamlingham@comcast.com>
Copilot AI review requested due to automatic review settings May 1, 2026 14:24
@gururaajar gururaajar requested a review from a team as a code owner May 1, 2026 14:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up systemd unit dependencies for WPEFramework WiFi and Network plugin initializer services by removing an unneeded direct dependency on iarmbusd.service, relying instead on the existing dependency chain through wpeframework-networkmanager.service.

Changes:

  • Removed iarmbusd.service from Requires= and After= in WiFi initializer unit.
  • Removed iarmbusd.service from Requires= and After= in Network initializer unit.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
systemd/system/wpeframework-wifi.service Drops direct iarmbusd.service dependency from WiFi plugin initializer ordering/requirements.
systemd/system/wpeframework-network.service Drops direct iarmbusd.service dependency from Network plugin initializer ordering/requirements.

Comment on lines +3 to +4
Requires=wpeframework.service wpeframework-networkmanager.service
After=wpeframework.service wpeframework-networkmanager.service
Copy link

Copilot AI May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wpeframework-networkmanager.service already has Requires=/After= on wpeframework.service, so listing wpeframework.service again here is redundant. Consider depending/ordering only on wpeframework-networkmanager.service to keep the dependency graph minimal and easier to maintain.

Suggested change
Requires=wpeframework.service wpeframework-networkmanager.service
After=wpeframework.service wpeframework-networkmanager.service
Requires=wpeframework-networkmanager.service
After=wpeframework-networkmanager.service

Copilot uses AI. Check for mistakes.
Comment on lines +3 to +4
Requires=wpeframework.service wpeframework-networkmanager.service
After=wpeframework.service wpeframework-networkmanager.service
Copy link

Copilot AI May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wpeframework-networkmanager.service already depends on and orders after wpeframework.service, so specifying wpeframework.service again in both Requires= and After= is redundant here. Consider keeping only wpeframework-networkmanager.service to reduce duplication in unit dependencies.

Suggested change
Requires=wpeframework.service wpeframework-networkmanager.service
After=wpeframework.service wpeframework-networkmanager.service
Requires=wpeframework-networkmanager.service
After=wpeframework-networkmanager.service

Copilot uses AI. Check for mistakes.
gururaajar added 4 commits May 1, 2026 11:04
Reason for Change: Removed unneeded dependency
Test Procedure: Check whether the plugin starts in sqeuence and there is no regression
Priority: P1
Risks: Medium
Signed-off-by: Gururaaja ESR<Gururaja_ErodeSriranganRamlingham@comcast.com>
Copilot AI review requested due to automatic review settings May 2, 2026 00:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants