RDK-60581: Systemd Service Dependency Clean-up#215
RDK-60581: Systemd Service Dependency Clean-up#215gururaajar wants to merge 5 commits intodevelopfrom
Conversation
Reason for Change: Removed unneeded dependency Test Procedure: Check whether the plugin starts in sqeuence and there is no regression Priority: P1 Risks: Medium Signed-off-by: Gururaaja ESR<Gururaja_ErodeSriranganRamlingham@comcast.com>
There was a problem hiding this comment.
Pull request overview
This PR cleans up systemd unit dependencies for WPEFramework WiFi and Network plugin initializer services by removing an unneeded direct dependency on iarmbusd.service, relying instead on the existing dependency chain through wpeframework-networkmanager.service.
Changes:
- Removed
iarmbusd.servicefromRequires=andAfter=in WiFi initializer unit. - Removed
iarmbusd.servicefromRequires=andAfter=in Network initializer unit.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| systemd/system/wpeframework-wifi.service | Drops direct iarmbusd.service dependency from WiFi plugin initializer ordering/requirements. |
| systemd/system/wpeframework-network.service | Drops direct iarmbusd.service dependency from Network plugin initializer ordering/requirements. |
| Requires=wpeframework.service wpeframework-networkmanager.service | ||
| After=wpeframework.service wpeframework-networkmanager.service |
There was a problem hiding this comment.
wpeframework-networkmanager.service already has Requires=/After= on wpeframework.service, so listing wpeframework.service again here is redundant. Consider depending/ordering only on wpeframework-networkmanager.service to keep the dependency graph minimal and easier to maintain.
| Requires=wpeframework.service wpeframework-networkmanager.service | |
| After=wpeframework.service wpeframework-networkmanager.service | |
| Requires=wpeframework-networkmanager.service | |
| After=wpeframework-networkmanager.service |
| Requires=wpeframework.service wpeframework-networkmanager.service | ||
| After=wpeframework.service wpeframework-networkmanager.service |
There was a problem hiding this comment.
wpeframework-networkmanager.service already depends on and orders after wpeframework.service, so specifying wpeframework.service again in both Requires= and After= is redundant here. Consider keeping only wpeframework-networkmanager.service to reduce duplication in unit dependencies.
| Requires=wpeframework.service wpeframework-networkmanager.service | |
| After=wpeframework.service wpeframework-networkmanager.service | |
| Requires=wpeframework-networkmanager.service | |
| After=wpeframework-networkmanager.service |
Reason for Change: Removed unneeded dependency Test Procedure: Check whether the plugin starts in sqeuence and there is no regression Priority: P1 Risks: Medium Signed-off-by: Gururaaja ESR<Gururaja_ErodeSriranganRamlingham@comcast.com>
…up-services into topic/RDK-60581
…up-services into topic/RDK-60581
…up-services into topic/RDK-60581
Reason for Change: Removed unneeded dependency
Test Procedure: Check whether the plugin starts in sqeuence and there is no regression
Priority: P1
Risks: Medium