Skip to content

Added flags to check MAPT feature mode check #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nvenka781 wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Added flags to check MAPT feature mode check #197

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
daa9ed4
Added flags to check MAPT feature mode check
nvenka781 Jan 28, 2026
2b199ce
Corrected compilation warnings
nvenka781 Jan 28, 2026
f51b330
Corrected function returns
nvenka781 Jan 28, 2026
bbafb1f
Corrected function returns
nvenka781 Jan 28, 2026
4eee3e8
Fixed some review comments
nvenka781 Jan 28, 2026
458358e
Addressed review comments
nvenka781 Jan 29, 2026
67bfe87
Addressed review comments
nvenka781 Jan 29, 2026
1cffb18
iCorrect MAPT feature id for stub
nvenka781 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions source/scripts/init/src/apply_system_defaults/apply_system_defaults.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1362,6 +1362,49 @@ static int ApplyPartnersObjectItemsIntoSysevents( char *pcPartnerID )
return 0;
}

#if defined(FEATURE_MAPT) || defined(FEATURE_SUPPORT_MAPT_NAT46)
#if defined(_ONESTACK_PRODUCT_REQ_)
// TODO: Temporary stub
static bool isFeatureSupportedInCurrentMode(int feature_id)
Comment thread
nvenka781 marked this conversation as resolved.
{
struct stat st;
(void)feature_id;

return (stat("/nvram2/mapt.support", &st) == 0) ? TRUE : FALSE;
Comment thread
nvenka781 marked this conversation as resolved.
Comment thread
nvenka781 marked this conversation as resolved.
}
Comment thread
nvenka781 marked this conversation as resolved.

#if 0
// uncomment later when actual check is finalized
static bool IsMAPTConflictingFeaturesEnabled(void)
Comment thread
nvenka781 marked this conversation as resolved.
{
struct {
const char *feature_syscfg;
const char *log;
} conflicts[] = {
{ "one_to_one_nat", "1-to-1 NAT" },
};
Comment thread
nvenka781 marked this conversation as resolved.
int range = (int)(sizeof(conflicts)/sizeof(conflicts[0]));

for (int i = 0; i < range; i++)
{
if ( 0 == IsValuePresentinSyscfgDB((char *)conflicts[i].feature_syscfg) )
{
APPLY_PRINT("MAP-T blocked: feature %s is already enabled\n", conflicts[i].log);
return TRUE;
}
Comment thread
nvenka781 marked this conversation as resolved.
Comment thread
nvenka781 marked this conversation as resolved.
}

return FALSE;
}
Comment thread
nvenka781 marked this conversation as resolved.
#endif

static bool IsMAPTConflictingFeaturesEnabled(void)
{
return FALSE;
Comment thread
nvenka781 marked this conversation as resolved.
Comment thread
nvenka781 marked this conversation as resolved.
}
#endif
#endif

STATIC void addInSysCfgdDB (char *key, char *value)
{
/* There are parameters which needs to be available in syscfg/PSM DBs
Expand Down Expand Up @@ -1562,6 +1605,18 @@ STATIC void addInSysCfgdDB (char *key, char *value)
#if defined(FEATURE_MAPT) || defined(FEATURE_SUPPORT_MAPT_NAT46)
if ( 0 == strcmp ( key, "Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.MAP-T.Enable") )
{
#if defined(_ONESTACK_PRODUCT_REQ_)
if (!isFeatureSupportedInCurrentMode(0 /* FEATURE_MAPT id */))
{
APPLY_PRINT("MAP-T enable rejected, unsupported mode\n");
return;
}
else if (IsMAPTConflictingFeaturesEnabled())
{
APPLY_PRINT("MAP-T enable rejected due to conflicting features\n");
return;
}
Comment thread
nvenka781 marked this conversation as resolved.
#endif
Comment thread
nvenka781 marked this conversation as resolved.
if ( 0 == IsValuePresentinSyscfgDB( "MAPT_Enable" ) )
{
set_syscfg_partner_values( value,"MAPT_Enable" );
Expand Down Expand Up @@ -1804,6 +1859,19 @@ STATIC void updateSysCfgdDB (char *key, char *value)
#if defined(FEATURE_MAPT) || defined(FEATURE_SUPPORT_MAPT_NAT46)
if ( 0 == strcmp ( key, "Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.MAP-T.Enable" ) )
{
#if defined(_ONESTACK_PRODUCT_REQ_)
if (!isFeatureSupportedInCurrentMode(0 /* FEATURE_MAPT id */))
{
APPLY_PRINT("MAP-T enable rejected, unsupported mode\n");
return;
}
else if (IsMAPTConflictingFeaturesEnabled())
{
APPLY_PRINT("MAP-T enable rejected due to conflicting features\n");
return;
Comment thread
nvenka781 marked this conversation as resolved.
}
#endif

set_syscfg_partner_values( value, "MAPT_Enable");
}
#endif
Expand Down
Loading