RDKB-64768 MTA Line Diagnostics page shows incorrect number of entries in business mode UI#52
Open
pavankumar464 wants to merge 2 commits intodevelopfrom
Open
RDKB-64768 MTA Line Diagnostics page shows incorrect number of entries in business mode UI#52pavankumar464 wants to merge 2 commits intodevelopfrom
pavankumar464 wants to merge 2 commits intodevelopfrom
Conversation
…number of entries in business mode UI
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the MTA Line Diagnostics page to render diagnostics sections dynamically from Device.X_CISCO_COM_MTA.LineTableNumberOfEntries instead of hard-coding individual line blocks, so the UI can scale beyond the original fixed set of lines.
Changes:
- Replaced per-line client-side click handlers with a generic diagnostics handler.
- Replaced hard-coded line 1–8 markup with a server-side loop that renders one diagnostics section per voice line.
- Refactored the diagnostics action handler to parse dynamic
get_statusN/start_diagnosticsNrequests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
source/Styles/xb3/jst/mta_Line_Diagnostics.jst |
Converts the page UI and client-side logic from fixed per-line blocks to dynamic rendering and generic request dispatch. |
source/Styles/xb3/jst/actionHandler/ajaxSet_mta_Line_Diagnostics.jst |
Refactors the backend action handler to support dynamic line lookup and diagnostics execution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKB-64768 MTA Line Diagnostics page shows incorrect number of entries in business mode UI