Skip to content

RDKEMW-16911 - L1 unit tests for xdialserver#199

Open
hgfell683 wants to merge 81 commits intodevelopfrom
feature/RDKEMW-16911
Open

RDKEMW-16911 - L1 unit tests for xdialserver#199
hgfell683 wants to merge 81 commits intodevelopfrom
feature/RDKEMW-16911

Conversation

@hgfell683
Copy link
Copy Markdown
Contributor

No description provided.

hgfell683 added 30 commits April 9, 2026 13:04
@hgfell683 hgfell683 marked this pull request as ready for review April 15, 2026 19:46
@hgfell683 hgfell683 requested a review from a team as a code owner April 15, 2026 19:46
Copilot AI review requested due to automatic review settings April 15, 2026 19:46
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an Autotools-driven L1 (unit-level) test harness for xdialserver, including a GitHub Actions workflow to build/run tests (with optional valgrind + coverage) in CI.

Changes:

  • Introduces run_L1Tests GoogleTest/GoogleMock binary with L1 test suites for server, platform, and utility layers.
  • Adds test stubs/mocks (incl. GSSDP) and CI-generated shadow headers to decouple tests from external SDK/framework headers.
  • Adds Autotools plumbing (configure.ac, Makefile.am files) plus a CI workflow to build, run, and publish artifacts.

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
tests/mocks/xdialserver/Makefile.am Placeholder Makefile for shared mock area.
tests/README.md Documents L1 test harness layout, build, CI, and pitfalls.
tests/Makefile.am Adds conditional test subdir build via --enable-l1tests.
tests/L1Tests/utils/test_gdialUtil.cpp Adds unit tests for gdial-util.c.
tests/L1Tests/utils/gdial_util_stubs.h Utility stubs header (currently placeholder).
tests/L1Tests/utils/gdial_util_stubs.cpp Utility stubs TU (currently placeholder).
tests/L1Tests/tests/gdialserver_ut.cpp Adds a template/placeholder test TU.
tests/L1Tests/test_main.cpp GTest/GMock main entrypoint for run_L1Tests.
tests/L1Tests/stubs/xdialserver_test_stubs.h Aggregated stub declaration header for shadow headers.
tests/L1Tests/stubs/xdialserver_test_stubs.cpp Provides stubs for logging symbols used by GDIAL_LOG* macros.
tests/L1Tests/stubs/gdial_cpp_test_stubs.hpp Minimal C++ shims for WPEFramework-ish types used by gdial.cpp.
tests/L1Tests/server/test_gdialserver_ut.cpp Tests for server/gdialserver_ut.cpp interactive command flow.
tests/L1Tests/server/test_gdialSsdp.cpp SSDP tests (init guards + dd.xml callback behavior).
tests/L1Tests/server/test_gdialShield.cpp Tests for gdial-shield server wrapping behavior.
tests/L1Tests/server/test_gdialService.cpp Tests for gdialService/gdialServiceImpl flows with conditional start.
tests/L1Tests/server/test_gdialServer.cpp Tests for gdial-app (state, lifecycle, additional-dial-data helpers).
tests/L1Tests/server/test_gdialRest.cpp REST server/builder tests using libsoup servers/sessions.
tests/L1Tests/server/gdial_rest_stubs.h REST stub header (currently placeholder).
tests/L1Tests/server/gdial_rest_stubs.cpp REST stub TU (currently placeholder).
tests/L1Tests/plat/test_gdialPlatUtil.cpp Tests for platform util functions + logging behavior.
tests/L1Tests/plat/test_gdialPlatDev.cpp Tests for platform dev power/network standby callbacks.
tests/L1Tests/plat/test_gdialPlatApp.cpp Tests for gdial-plat-app guards, sync calls, and async handles.
tests/L1Tests/plat/test_gdialPlat.cpp Tests for gdial_app_registry behavior + disposal.
tests/L1Tests/plat/test_gdialCpp.cpp Pulls real gdial.cpp into a test TU with symbol renames and exercises key paths.
tests/L1Tests/plat/gdial_plat_stubs.h Platform stubs header (currently placeholder).
tests/L1Tests/plat/gdial_plat_stubs.cpp Platform stub TU intentionally exporting no symbols.
tests/L1Tests/plat/gdial_os_stubs.cpp Stubs for the “OS” layer under gdial-plat-app.c and for gdial.hpp APIs.
tests/L1Tests/mocks/gssdp_mock.c Minimal GSSDP mocks to allow SSDP paths to execute under test.
tests/L1Tests/mocks/Makefile.am Placeholder Makefile for mocks subdir.
tests/L1Tests/mocks/IarmBusMock.h Placeholder IARM bus mock header.
tests/L1Tests/mocks/IarmBusMock.cpp Placeholder IARM bus mock TU.
tests/L1Tests/Makefile.am Build recipe for run_L1Tests (sources, include paths, link flags).
configure.ac Adds Autotools configuration, dependency checks, and --enable-l1tests.
Makefile.am Top-level Automake entry to build tests subdir.
.github/workflows/L1-tests.yml CI workflow to build/run tests (valgrind + coverage + artifacts).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/L1Tests/utils/test_gdialUtil.cpp
Comment thread tests/L1Tests/server/test_gdialServer.cpp
Comment thread tests/L1Tests/plat/test_gdialPlat.cpp
Comment thread tests/L1Tests/server/test_gdialSsdp.cpp
Comment thread tests/L1Tests/server/test_gdialSsdp.cpp
Comment thread tests/L1Tests/server/test_gdialSsdp.cpp
Comment thread configure.ac
Comment thread tests/L1Tests/server/test_gdialserver_ut.cpp
Comment thread tests/L1Tests/Makefile.am
Comment thread tests/L1Tests/tests/gdialserver_ut.cpp
Copilot AI review requested due to automatic review settings April 15, 2026 20:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/L1Tests/tests/gdialserver_ut.cpp
Comment thread .github/workflows/L1-tests.yml
Comment thread tests/L1Tests/server/test_gdialserver_ut.cpp
Comment thread tests/L1Tests/server/test_gdialSsdp.cpp
Comment thread tests/L1Tests/server/test_gdialSsdp.cpp
Comment thread .github/workflows/L1-tests.yml
Comment thread tests/L1Tests/server/test_gdialserver_ut.cpp
Copilot AI review requested due to automatic review settings April 20, 2026 14:51
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/L1Tests/server/test_gdialserver_ut.cpp
Comment thread tests/L1Tests/server/test_gdialserver_ut.cpp
Comment thread configure.ac
Copilot AI review requested due to automatic review settings April 20, 2026 16:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 8 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/L1Tests/server/test_gdialserver_ut.cpp
Comment thread tests/L1Tests/server/test_gdialSsdp.cpp
Comment thread tests/L1Tests/server/test_gdialSsdp.cpp
Comment thread tests/L1Tests/server/test_gdialSsdp.cpp
Comment thread tests/L1Tests/plat/gdial_os_stubs.cpp
Comment thread tests/L1Tests/Makefile.am
Comment thread tests/L1Tests/Makefile.am
Comment thread tests/L1Tests/tests/gdialserver_ut.cpp
@yuvaramachandran-gurusamy
Copy link
Copy Markdown
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants