Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a telemetry (T2) marker when DNSSec is attempted in residential mode, supporting the “Security Edge for business-only” behavior by making non-business usage observable via telemetry.
Changes:
- Emit a T2 event when
DNSSecEnableis set in residential mode (OneStack builds). - Move the telemetry header include from
cosa_xdns_apis.cintocosa_xdns_apis.h.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| source/dmlxdns/cosa_xdns_dml.c | Emits XDNS_DNSSec_NotSupported telemetry event when DNSSec is not supported in residential mode. |
| source/dmlxdns/cosa_xdns_apis.h | Adds telemetry header include (currently increases public-header coupling). |
| source/dmlxdns/cosa_xdns_apis.c | Removes telemetry header include (now relies on the header’s transitive include). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apattu200
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Handle Security Edge feature for business - Add T2 markers
Test Procedure:
Functionality of the following DMLs need to be tested:
Above mentioned DML parameters SHOULD work only if the devicemode is business.
Risks: Low
Priority: P1
Signed-off-by: Santhosh_GujulvaJagadeesh@comcast.com