Skip to content

RDKB-63135, RDKB-63664 : Handle Security Edge feature for business - Add T2 markers#18

Merged
apattu200 merged 1 commit intodevelopfrom
feature/onestack_add_t2_event_marker
Mar 30, 2026
Merged

RDKB-63135, RDKB-63664 : Handle Security Edge feature for business - Add T2 markers#18
apattu200 merged 1 commit intodevelopfrom
feature/onestack_add_t2_event_marker

Conversation

@SanthoshGujulvajagadeesh
Copy link
Copy Markdown
Contributor

Reason for change: Handle Security Edge feature for business - Add T2 markers
Test Procedure:

  • residential and business devicemode needs to be tested.

Functionality of the following DMLs need to be tested:

Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.EnableMultiProfileXDNS
Device.X_RDKCENTRAL-COM_XDNS.DNSSecEnable

Above mentioned DML parameters SHOULD work only if the devicemode is business.

Risks: Low
Priority: P1

Signed-off-by: Santhosh_GujulvaJagadeesh@comcast.com

Copilot AI review requested due to automatic review settings March 30, 2026 06:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a telemetry (T2) marker when DNSSec is attempted in residential mode, supporting the “Security Edge for business-only” behavior by making non-business usage observable via telemetry.

Changes:

  • Emit a T2 event when DNSSecEnable is set in residential mode (OneStack builds).
  • Move the telemetry header include from cosa_xdns_apis.c into cosa_xdns_apis.h.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
source/dmlxdns/cosa_xdns_dml.c Emits XDNS_DNSSec_NotSupported telemetry event when DNSSec is not supported in residential mode.
source/dmlxdns/cosa_xdns_apis.h Adds telemetry header include (currently increases public-header coupling).
source/dmlxdns/cosa_xdns_apis.c Removes telemetry header include (now relies on the header’s transitive include).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/dmlxdns/cosa_xdns_dml.c
Comment thread source/dmlxdns/cosa_xdns_apis.h
@apattu200 apattu200 merged commit e880eb8 into develop Mar 30, 2026
13 of 14 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RDKB-63135, RDKB-63664 : Handle Security Edge feature for business - Add T2 markers

3 participants