Improve accuracy and usefulness of the "No TODOs" CI workflow #142
Merged
rdw-software merged 3 commits intomainfrom Nov 17, 2021
Merged
Improve accuracy and usefulness of the "No TODOs" CI workflow #142rdw-software merged 3 commits intomainfrom
rdw-software merged 3 commits intomainfrom
Conversation
It makes no sense to fail the CI when TODOs etc. are actually removed, as that's the whole point of tracking them: New ones should not be added and existing ones should be (eventually) converted to issues.
This should help seeing where the change originates.
There's obviously going to be failures whenever it is edited, so ignoring that only makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some issues that I stumbled upon while wrapping up #130 , which should now be resolved: